-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
fix: playwright_stealth import and stealth application #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sjoeborg
wants to merge
1
commit into
unclecode:develop
Choose a base branch
from
Sjoeborg:fix/stealth-context
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
❓ Verification inconclusive
Two fixes for stealth application: await and coverage of existing pages.
awaitonadd_init_script(async API); without it, stealth might not register before page creation.add_init_scriptaffects new documents only. If the connected persistent context already has open pages, consider reloading them or documenting that callers should open new pages.if self.config.enable_stealth and not self.use_undetected and self.config.browser_type == "chromium": from playwright_stealth import stealth prop = stealth.Properties(browser_type=stealth.BrowserType.CHROME) stealth_script = stealth.combine_scripts(prop, None) await stealth.generate_stealth_headers_async(prop, context) - context.add_init_script(stealth_script) + await context.add_init_script(stealth_script)Optional: reload existing pages after applying stealth to persistent contexts:
Please confirm whether stealth must apply to already-open pages in managed/persistent sessions or if “new pages only” is acceptable for your use case.
Fix: await context.add_init_script and reload open pages in persistent contexts
File: crawl4ai/browser_manager.py (around lines 835–842)
if self.config.enable_stealth and not self.use_undetected and self.config.browser_type == "chromium": from playwright_stealth import stealth prop = stealth.Properties(browser_type=stealth.BrowserType.CHROME) stealth_script = stealth.combine_scripts(prop, None) await stealth.generate_stealth_headers_async(prop, context) - context.add_init_script(stealth_script) + await context.add_init_script(stealth_script)Optional: reload existing pages after add_init_script when using persistent/connected contexts:
Confirm whether stealth must apply to already-open pages in persistent sessions or if "new pages only" is acceptable.
🤖 Prompt for AI Agents