Conversation
FliPPeDround
force-pushed
the
chore/update-deps
branch
from
f3db567 to
c001163
Compare
WalkthroughBump devDependency versions in three template package.json files: Changes
Sequence Diagram(s)(omitted — changes are dependency version updates only, no runtime/control-flow changes) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/core/template/plugin/root/package.json (1)
1-5: Optional: add guardrails for template consumers.Consider adding:
- engines and packageManager fields to reduce environment drift.
- a basic “scaffold smoke test” in CI to install and lint one generated template.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
packages/core/template/UI/skiyee/package.json(1 hunks)packages/core/template/config/lint/package.json(1 hunks)packages/core/template/plugin/root/package.json(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/core/template/config/lint/package.json (1)
packages/info/src/utils/dependencies.ts (1)
getUniHelperDependencies(14-21)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: stable - aarch64-apple-darwin - node@20
- GitHub Check: stable - aarch64-pc-windows-msvc - node@20
- GitHub Check: stable - i686-pc-windows-msvc - node@20
- GitHub Check: stable - x86_64-apple-darwin - node@20
- GitHub Check: stable - x86_64-pc-windows-msvc - node@20
🔇 Additional comments (3)
packages/core/template/UI/skiyee/package.json (1)
6-6: Confirm@skiyee/ui-preset@^0.0.6peerDependency bump
The only peerDependency change is adding"unocss": ">=66.0.0"—ensure all template consumers meet this requirement; manually review the full changelog in the package’s repo (npm metadata doesn’t expose it) and regenerate the workspace lockfile for templates.packages/core/template/config/lint/package.json (1)
7-9: Confirm @uni-helper/eslint-config@^0.5.0 compatibility with ESLint v9Run from
packages/core/template/config/lint:npm install npx eslint --version # expect v9.x echo '/* temp */' > __tmp__.js npx eslint --print-config __tmp__.js >/dev/null rm __tmp__.js npm view @uni-helper/eslint-config@0.5.0 peerDependencies --jsonEnsure the
--print-configrun succeeds and that peerDependencies ("eslint": "^9.10.0","@antfu/eslint-config": "^5.0.0") are installed or bundled.packages/core/template/plugin/root/package.json (1)
3-3: Check @uni-ku/root plugin compatibility with Vite 6.x
@uni-ku/root@^1.3.4 declares a peerDependency on "vite": "^5.0.0", but packages/ui uses Vite "^6.0.4". Rebuild a Vite 6 sample project to confirmplugin.id === 'root'and hook order haven’t changed; if you encounter issues, bump the peerDependency and update the plugin code accordingly.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/core/template/UI/skiyee/package.json (1)
6-6: Consider pinning exact versions in templates for reproducible scaffolds.Caret ranges can pull newer minor/patches at user-scaffold time, causing nondeterministic results.
Apply this diff if you want deterministic installs from the template:
- "@skiyee/ui-preset": "^0.0.7", + "@skiyee/ui-preset": "0.0.7",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/core/template/UI/skiyee/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: stable - aarch64-pc-windows-msvc - node@20
- GitHub Check: stable - x86_64-pc-windows-msvc - node@20
- GitHub Check: stable - x86_64-apple-darwin - node@20
- GitHub Check: stable - i686-pc-windows-msvc - node@20
🔇 Additional comments (1)
packages/core/template/UI/skiyee/package.json (1)
6-6: LGTM on the version bump.Looks straightforward; no other fields changed.
| }, | ||
| "devDependencies": { | ||
| "@skiyee/ui-preset": "^0.0.5", | ||
| "@skiyee/ui-preset": "^0.0.7", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify publish status and peer deps of @skiyee/ui-preset@0.0.7.
Ensure 0.0.7 is published and that any peerDependencies are satisfied by this template (or by the generated app).
Run:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Confirm the version exists and see release info
npm view @skiyee/ui-preset@0.0.7 version dist-tags --json
# 2) Inspect peer dependencies to ensure they're satisfied by the template
npm view @skiyee/ui-preset@0.0.7 peerDependencies --json
# 3) Check for multiple versions referenced across templates (keep them consistent)
rg -nP '"@skiyee/ui-preset"\s*:\s*"[^\"]+"' -g '**/package.json' -C2Length of output: 648
🏁 Script executed:
#!/bin/bash
# Verify if unocss is included to satisfy peerDependencies of @skiyee/ui-preset@0.0.7
grep -n '"unocss"' packages/core/template/UI/skiyee/package.json || true
cat packages/core/template/UI/skiyee/package.jsonLength of output: 283
Declare unocss@>=66.0.0 to satisfy @skiyee/ui-preset peerDependency
packages/core/template/UI/skiyee/package.json is missing the required peerDependency “unocss” (>=66.0.0) of @skiyee/ui-preset@0.0.7—add unocss@^66.0.0 to dependencies.
🤖 Prompt for AI Agents
In packages/core/template/UI/skiyee/package.json around line 6, the dependency
list includes "@skiyee/ui-preset": "^0.0.7" but does not declare the required
peerDependency "unocss" (>=66.0.0); add "unocss": "^66.0.0" to this package.json
dependencies (or devDependencies if appropriate) so that the @skiyee/ui-preset
peer requirement is satisfied, then run install to update lockfile.
1 participant
Update dependencies
Summary by CodeRabbit