Skip to content

change view name / TokenRequiredView #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domdinicola merged 1 commit into from
May 26, 2026
Merged

change view name / TokenRequiredView #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hope_api_auth/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from .models import APILogEntry, GrantClass


class LoggingAPIView(APIView):
class TokenRequiredView(APIView):
permission_classes = [
GrantedPermission,
]
Expand Down Expand Up @@ -42,5 +42,5 @@ def handle_exception(self, exc: Exception) -> Any:
return super().handle_exception(exc)


class LoggingAPIViewSet(ModelViewSet, LoggingAPIView):
class TokenRequiredViewSet(ModelViewSet, TokenRequiredView):
pass
14 changes: 7 additions & 7 deletions tests/views/test_logging_api_view.py → tests/views/test_token_required_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
from rest_framework.test import APIRequestFactory, force_authenticate

from hope_api_auth.models import APILogEntry, APIToken, GrantClass
from hope_api_auth.views import LoggingAPIView
from hope_api_auth.views import TokenRequiredView

ALL_HTTP_METHODS = "GET", "POST", "PUT", "DELETE"
NOT_LOGGED_HTTP_METHODS = tuple(set(ALL_HTTP_METHODS) - set(LoggingAPIView.log_http_methods))
NOT_LOGGED_HTTP_METHODS = tuple(set(ALL_HTTP_METHODS) - set(TokenRequiredView.log_http_methods))

LOGGED_STATUSES = status.HTTP_200_OK, status.HTTP_404_NOT_FOUND, status.HTTP_500_INTERNAL_SERVER_ERROR
NOT_LOGGED_STATUSES = status.HTTP_301_MOVED_PERMANENTLY, status.HTTP_302_FOUND
Expand Down Expand Up @@ -49,7 +49,7 @@ def http_method_handler_mock(http_status_code: int) -> Mock:

@pytest.fixture
def test_view(http_method_handler_mock: Mock) -> Callable:
class TestView(LoggingAPIView):
class TestView(TokenRequiredView):
def __getattr__(self, item) -> Callable:
if item.upper() in ALL_HTTP_METHODS:
return http_method_handler_mock
Expand All @@ -62,7 +62,7 @@ def __getattr__(self, item) -> Callable:


@pytest.mark.parametrize("http_status_code", LOGGED_STATUSES, indirect=True)
@pytest.mark.parametrize("http_method_name", LoggingAPIView.log_http_methods, indirect=True)
@pytest.mark.parametrize("http_method_name", TokenRequiredView.log_http_methods, indirect=True)
def test_dispatch_methods_logged(
http_request: WSGIRequest,
test_view: Callable,
Expand All @@ -88,7 +88,7 @@ def test_dispatch_methods_not_logged_methods(http_request: WSGIRequest, test_vie


@pytest.mark.parametrize("http_status_code", NOT_LOGGED_STATUSES, indirect=True)
@pytest.mark.parametrize("http_method_name", LoggingAPIView.log_http_methods, indirect=True)
@pytest.mark.parametrize("http_method_name", TokenRequiredView.log_http_methods, indirect=True)
def test_dispatch_methods_not_logged_statuses(http_request: WSGIRequest, test_view: Callable) -> None:
test_view(http_request)

Expand All @@ -106,7 +106,7 @@ def test_dispatch_methods_not_logged_statuses(http_request: WSGIRequest, test_vi
def test_handle_exception_permission_denied(
super_mock: Mock, permission: GrantClass | None, expected_error_message: str
) -> None:
view = LoggingAPIView()
view = TokenRequiredView()
view.permission = permission

view.handle_exception(PermissionDenied())
Expand All @@ -121,7 +121,7 @@ def test_handle_exception_permission_denied(

@patch("hope_api_auth.views.super")
def test_handle_exception_not_permission_denied(super_mock: Mock) -> None:
LoggingAPIView().handle_exception(exception := Exception())
TokenRequiredView().handle_exception(exception := Exception())

super_handle_exception_mock = super_mock.return_value.handle_exception
super_handle_exception_mock.assert_called_once()
Expand Down
Loading