[AB#301335] Add Latin name fields for beneficiaries - #5913
Draft
mmaciekk wants to merge 88 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (98.44%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5913 +/- ##
=========================================
Coverage 97.08% 97.09%
=========================================
Files 500 501 +1
Lines 34566 34687 +121
Branches 4104 4123 +19
=========================================
+ Hits 33559 33678 +119
- Misses 559 560 +1
- Partials 448 449 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…301335/handle-local-names
# Conflicts: # src/frontend/src/restgenerated/models/HouseholdMember.ts
# Conflicts: # src/hope/apps/household/migrations/0039_migration.py
mmaciekk
changed the title
…to 301335/handle-local-names
# Conflicts: # src/hope/apps/household/migrations/0040_migration.py
Jeeziorny
marked this pull request as draft
June 22, 2026 13:29
Contributor
|
If it's blocked it's blocked (not opened) |
pavlo-mk
removed request for
Jeeziorny,
MarekBiczysko,
johniak,
nerjan and
pkujawa
July 1, 2026 10:38
# Conflicts: # tests/unit/api_contract/_api_checker/test_payments/_api_rest_business-areas_business-area-0_programs_c6r4_payment-plans_911e9fb2-a41a-4d07-97c2-29722c9d749a_payments_f533f1fa-fbb4-4719-a515-6c99d493fe57_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_verification_records/_api_rest_business-areas_business-area-0_programs_43mc_payment-verifications_b546a8d8-a5c1-4161-b3fb-6186f0ca192f_verifications_480e9f86-3a14-4620-b6eb-0cb5eea687fa_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json
full_name_latin only exists in indexes rebuilt after the mapping change, so the clause silently matches nothing on programs that are not reindexed yet. Keep it out of the query until the fleet reindex is done and the flag is flipped in constance. Serializers, the API response and the DB search fallback are unaffected - latin names stay visible everywhere regardless of the flag.
… keyset batches, JSONL failure report)
johniak
changed the title
…vance name changes
…l-names # Conflicts: # tests/unit/api_contract/_api_checker/test_payments/_api_rest_business-areas_business-area-0_programs_pd2p_payment-plans_ad89a016-ec17-43c6-81ab-729de501c8d8_payments_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_payments/_api_rest_business-areas_business-area-0_programs_pd2p_payment-plans_ad89a016-ec17-43c6-81ab-729de501c8d8_payments_8a21fe13-2603-4ac3-9878-0acbf714cf73_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_payments_global/_api_rest_business-areas_business-area-0_payments_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_verification_records/_api_rest_business-areas_business-area-0_programs_1cpl_payment-verifications_cb35a199-c561-4206-a989-065b41e8f319_verifications_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_verification_records/_api_rest_business-areas_business-area-0_programs_1cpl_payment-verifications_cb35a199-c561-4206-a989-065b41e8f319_verifications_f6730d02-ba17-4532-8d32-a3d456eb2768_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json
…orms Add a "Transliterate Latin names automatically" checkbox (default on) to the Individual Data Update, People Data Update and Add Individual forms, and send individual_data.transliterate_latin_names on both the create and update paths. Without it the backend rejects any name change that carries no *_latin twin, and the frontend surfaced that as an unexplained nested DRF 400. The rule is now mirrored client-side so the form fails fast, latin inputs are hidden while the checkbox is on, and stale latin values are dropped from the payload since explicit latin values win over transliteration server side. The flag is also skipped in the approval screens - it is a UX flag, not a field change, and it would otherwise have counted as an unapproved change.
…301335/handle-local-names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#301335
Beneficiary names can be written in a local script (e.g. Cyrillic). This PR adds
*_latinfields that store the same names in the Latin alphabet. The existing name fields are not changed.Changes
given/middle/family/full_name_latinonIndividual, only Latin letters allowedES_USE_LATIN_NAMESconstance flag (needs fleet reindex first), plain DB search works right away*_latinfields returned by individual/household/grievance/payment endpointsRollout order
es_reindex --all→ 4. turn onES_USE_LATIN_NAMES