Skip to content

emphasised dpg indicators met#168

Open
Neha9849 wants to merge 1 commit into
unicef:mainfrom
Neha9849:issue#159
Open

emphasised dpg indicators met#168
Neha9849 wants to merge 1 commit into
unicef:mainfrom
Neha9849:issue#159

Conversation

@Neha9849

Copy link
Copy Markdown
Member

No description provided.

Comment thread assets/css/style.css
}

.sdgs img{
width:150px

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hard-codes pixels into the design, so these changes will not be responsive based on screen size. This is similar feedback to what I gave in #146 and #147. Instead of adding more custom CSS changes, again I push for using the existing Bootstrap classes, which saves us the effort of defining and testing our own custom classes. Bootstrap has already done a lot of the hard work for us.

@justwheel justwheel added the ?: blocked Progress blocked by another task or issue label Sep 16, 2022
@justwheel

Copy link
Copy Markdown
Member

These changes could fit in the Team Profiles section after the CSS reorganization in PR #179:

/* Team Profiles: start *******************************************************/
.startupCard {
align-items: center;
display: flex;
flex-direction: column;
justify-content: space-between;
}
/* Team Profiles: end *********************************************************/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

?: blocked Progress blocked by another task or issue T: improvement Improves on something that already exists

Projects

Status: Waiting on external

Development

Successfully merging this pull request may close these issues.

2 participants