ICU-22984 Generate old Java monkeys #3301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
markusicu
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Error: RBBITestMonkey.TestLineMonkey:1694->RunMonkey:1459 » IllegalArgument Rule $NU × ($AL | $HL) found a break at a position which does not correspond to an index in the original string
Error: RBBITestMonkey.TestRTLineMonkey:1763->RunMonkey:1459 » IllegalArgument Rule $NU × ($AL | $HL) found a break at a position which does not correspond to an index in the original string
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/rbbi/RBBITestMonkey.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/rbbi/RemapRule.java
Outdated
Show resolved
Hide resolved
markusicu
reviewed
Dec 23, 2024
|
changes lgtm but the CI check still fails |
|
works in Java 11, 17, 21, but fails in Java 8; some Java regex behavior change? maybe skip these tests on Java 8?? |
|
Well, I ended up narrowing down the Java 8 inconsistency to something about surrogates, so I changed the code to not produce nor match them before Java 9. |
markusicu
reviewed
Jan 21, 2025
| @@ -1433,6 +1433,12 @@ void RunMonkey(BreakIterator bi, RBBIMonkeyKind mk, String name, int seed, int | |||
| if (c < 0) { // TODO: deal with sets containing strings. | |||
| errln("c < 0"); | |||
| } | |||
| // Do not emit surrogates on Java 8, as the behaviour of regular expressions that | |||
| // match surrogates differs there. | |||
| if (System.getProperty("java.version").startsWith("1.") && | |||
There was a problem hiding this comment.
Please pull the System.getProperty() and version check out of the loop.
| // Do not emit surrogates on Java 8, as the behaviour of regular expressions that | ||
| // match surrogates differs there. | ||
| if (System.getProperty("java.version").startsWith("1.") && | ||
| Character.isSurrogate((char)c)) { |
There was a problem hiding this comment.
This also triggers for U+1D800, U+2D800, ...
Please check Character.isBmpCodePoint(c) first.
(Don't ask me why isSurrogate() does not take an int code point.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from the C++ in #3287 and hammered upon until it compiled and passed.
Checklist