Clarifications to 'Resolved Values' section #1081
Open
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
requested changes
Jun 13, 2025
Comment on lines
+180
to
+181
| > - In some cases (such as in a number formatting function), `getResult()` would | ||
| > return the _operand_ of the function that returned the `MessageValue`. In other |
There was a problem hiding this comment.
This is incorrect; for an expression like {42 :number} the function is expected to return the numerical value 42 rather than the literal string '42', which is the operand here.
Also, please do use semantic line breaks in spec text.
Comment on lines
+184
to
+185
| > - The `directionality()`, `isolate()`, and `isLiteralOptionValue()` methods | ||
| > fulfill the requirements and recommendations mentioned earlier in this section. |
There was a problem hiding this comment.
"earlier" is incorrect, as at least isolation is only mentioned in bidi handling.
Suggested change
| > - The `directionality()`, `isolate()`, and `isLiteralOptionValue()` methods | |
| > fulfill the requirements and recommendations mentioned earlier in this section. | |
| > - The `directionality()`, `isolate()`, and `isLiteralOptionValue()` methods | |
| > fulfill requirements and recommendations mentioned elsewhere in this specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was re-reading the
MessageValueexample and noticed that it's easy to skip over what the last three methods are for, so I added a reference to the earlier text.I also thought that the
getValue()method could have another name, since it's confusing to think about the "value" that it returns, vs. the enclosingMessageValue. The name I thought of wasgetResult(), but I'm open to other suggestions. I also thought it needed a little more explanation.