-
-
Notifications
You must be signed in to change notification settings - Fork 48
More Unicode 17.0 Confusables #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit c1dd3ea.
@roozbehp please note there is one commented out that appeared to be a circular reference which caused generating to fail. Please review.
@roozbehp in the PAG ticket, there was an item marked as "remove" (from a generated file) that seems to come from a difficult tangle of other confusables already listed. I was not easily able to work out what that was, so left it. Please review and suggest the line/code in confusables-source.txt that causes this and I can remove and regenerate.
The way the code works, if you introduce an intermediary that matches both of those (eg half-way between), it will form a transitive closure. |
I think the source of the problem is adding these three lines without removing their previous confusables:
@josh-hadley, please comment these three lines out for now and regenerate. We'll figure out how to add them properly later. |
@roozbehp looks like that did the trick (for eliminating the test failure at least). Please continue reviewing with the updated data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will try to figure out how to properly fix the commented-out lines in the next round.
I got a new laptop today, so I set up unicodetools and figured out what else needs to change in order to uncomment the new additions. Pushed my changes to the same branch, so they can all land together. |
@markusicu do you want to give this a quick 👀 before merge (squash-and-merge)? |
This PR rolls up several individual confusables items:
Each item has 2 commits: one for the
confusables-source.txt
and a second one containing the generated data from the updated source.