Fix Typos and Source Paths in README #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeneyops
reviewed
Sep 12, 2017
There was a problem hiding this comment.
Thanks for the PR and your interest in the module. I verified that Terraform parses the source URLs in either order.
My motivation for the ordering was to split the source reference at the Terraform specific delimiter. That way the Git URL fragment is independently valid.
I do see your point in the light of standard URL convention though. I could go either way. Let me look around the community a bit and see what others are doing.
Thanks!
| @@ -175,11 +175,11 @@ Name | Type | Required | Description | |||
|
|
|||
| ```js | |||
| module "vpc_base" { | |||
| source = "github.com/terraform-aws-vpc?ref=master//base" | |||
| source = "github.com/terraform-aws-vpc//base?ref=master" | |||
There was a problem hiding this comment.
Looks like we missed unifio here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a few issues in the README while trying these modules out.