Skip to content

fix: align off-policy logger timing and header - #893

Merged
TATP-233 merged 4 commits into
mainfrom
fix/offpolicy-logger-timing-header
Aug 4, 2026
Merged

fix: align off-policy logger timing and header#893
TATP-233 merged 4 commits into
mainfrom
fix/offpolicy-logger-timing-header

Conversation

@TATP-233

@TATP-233 TATP-233 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • start off-policy elapsed-time and ETA accounting only after the replay buffer first becomes ready for learner work, excluding collector startup, MuJoCo chunk tuning, and initial replay warm-up
  • align the completed-run training_wall_time_sec and Perfetto learner/training_e2e window with the same boundary for single-GPU runners
  • move the algorithm, task, and current iteration into the panel title (🚀 UniLab Off-Policy Training | FastSAC | G1WalkFlat | iter 5000/5000), remove iteration from the compact statistics row, and remove the normal | Training suffix while preserving error statuses
  • keep Reward component labels such as penalty action rate, penalty ang vel xy, and penalty orientation on one line in narrow terminals
  • render Env Step detail timings as dim cyan children with right-aligned mirrored tree connectors (12.5ms ─┤, 1.0ms ─┤, 0.5ms ─┘), keeping the tree aligned across different numeric widths
  • cover the logger output and timer boundary across legacy single-GPU, double-buffer, and multi-GPU runners

Linked Work

  • Issue: none
  • Milestone: none

Validation

  • make check
  • uv run pytest -m "not slow"
  • Additional task-specific validation listed below

Commands actually run:

uv run pytest tests/algos/test_offpolicy_logger.py -q
uv run pytest tests/algos/test_offpolicy_logger.py tests/algos/test_offpolicy_runner_unit.py -q
uv run pytest tests/algos/test_offpolicy_logger.py tests/algos/test_offpolicy_runner_unit.py tests/utils/test_experiment_tracking.py -q
make test-all

make test-all: 1634 passed, 29 skipped, 267 deselected, 1 xfailed; benchmark smoke test passed (2 platform-optional MLX entries skipped).

Impact

  • Backend impact: none
  • Platform impact: both
  • Training effect expected: no; training behavior is unchanged, while terminal and run-summary timing accounting changes

Artifacts

  • W&B: none
  • benchmark result: benchmark smoke test passed
  • video / screenshot: none
  • ONNX / checkpoint: none

Checklist

  • Added or updated tests where needed
  • Updated docs if behavior or workflow changed (not needed; terminal presentation only)
  • Linked the driving issue (none provided)
  • Noted any follow-up work explicitly (none)

@TATP-233
TATP-233 requested a review from caozx1110 as a code owner August 4, 2026 09:43
@TATP-233
TATP-233 merged commit 9a91b8c into main Aug 4, 2026
6 checks passed
@TATP-233
TATP-233 deleted the fix/offpolicy-logger-timing-header branch August 4, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant