ci: isolate and cache Numba benchmark smoke - #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/benchmarktobenchmark/envslow, retaining it in the slow suite without its fixed startup timeout flaking standard CIMotivation
The Numba benchmark contracts performed cold JIT compilation inside the main coverage job. On GitHub's ephemeral runners, the two largest cases accounted for roughly 131 seconds. Local cold/warm measurements for the extracted contracts were 21.10 seconds and 1.43 seconds respectively.
The real-spawn dead-collector regression also has a fixed five-second child startup wait and has failed intermittently on slow
ubuntu-slimrunners before reaching the production helper under test. It remains covered by the slow suite.Validation
make test-all(completed before PR creation, confirmed by requester)make test(1621 passed, 29 skipped, 267 deselected, 1 xfailed)uv run --no-sync pytest -q benchmark/env/test_g1_joystick_numba_benchmark.py benchmark/env/test_g1_motion_tracking_numba_benchmark.py benchmark/env/test_numba_random_noise_benchmark.py(13 passed)uv run --no-sync python benchmark/smoke_test.pyuv run pytest -q tests/algos/test_offpolicy_double_buffer_runner.py(66 passed, 1 deselected)uv run pytest -q -m slow tests/algos/test_offpolicy_double_buffer_runner.py::test_safe_put_trainer_done_does_not_deadlock_on_real_dead_collector(1 passed)git diff --check