feat(clientsv2): add option to disable external telemetry#344
Open
feat(clientsv2): add option to disable external telemetry#344
Conversation
Contributor
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a values flag to disable external telemetry (Grafana Faro) calls from the unionconsole frontend. Needed for egress-restricted selfhosted/selfmanaged deployments where all outbound traffic is blocked.
Default is
true(unchanged behavior). Backward compatible — downstream values files that omit the newtelemetryblock render byte-identical output.Changes
charts/controlplane/values.yaml— addconsole.telemetry.externalEnabled: truedefault with inline doc.charts/controlplane/templates/console/deployment.yaml— whenexternalEnabledis explicitly set tofalse, appendDISABLE_EXTERNAL_TELEMETRY=truetoconsole env. UseshasKey+ explicit false check rather than| default true, which mis-handles false-as-no-value.