Fix RBAC table inconsistencies in security docs#876
Closed
Conversation
- Remove invalid `post` K8s RBAC verb from operator-system - Remove `(RO)` marker from pods in union-executor and flytepropeller-role (both have write verbs for pods) - Use full ARN patterns consistently in IAM roles table Needs review from @EngHabu to confirm accuracy. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
ppiegaze
requested review from
cosmicBboy,
kumare3 and
samhita-alla
as code owners
Deploying docs with
|
| Latest commit: |
4bd2db8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3fe6e2a1.docs-dog.pages.dev |
| Branch Preview URL: | https://peeter-security-rbac-fixes.docs-dog.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the security documentation to correct and standardize RBAC and IAM table entries, addressing inconsistencies introduced/identified during the security section restructure (PR #871).
Changes:
- Removes the invalid Kubernetes RBAC verb
postfrom theoperator-systemClusterRole verbs list. - Removes contradictory
(RO)markers frompodsresources where the roles clearly have write verbs. - Standardizes AWS IAM Role ARN patterns in the IAM roles table to consistently use full
arn:aws:iam::<account-id>:role/...format.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| content/security/kubernetes-rbac-data-plane.md | Fixes RBAC table accuracy by removing invalid verb and inconsistent read-only markers. |
| content/security/aws-iam-roles.md | Normalizes IAM role ARN pattern formatting across control/data plane rows for consistency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Closing. #907 supersedes this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postK8s RBAC verb fromoperator-systemrole(RO)marker frompodsresource inunion-executorandflytepropeller-role(both have write verbs)arn:aws:iam::<account-id>:role/...ARN patterns consistently in IAM roles tableBased on Copilot review suggestions from PR #871. Needs @EngHabu review to confirm accuracy.
Test plan
🤖 Generated with Claude Code