Add suport for the PlayerCountMax#238
Merged
corp-0 merged 3 commits intounitystation:developfrom Mar 30, 2025
Merged
Conversation
Member
|
The code looks good. To avoid fails on the format check, you can install and run dotnet-format locally next time. We have to solve some issues with our build checks, it seems. I can take a look once my electricity is back. |
Contributor
Author
|
i installed it locally now and fixed it for realzies this time, maybe the builds are broken because the tests are failing? |
Member
|
Since I merged the version bump, you have to rebase your other PRs to get that change |
Contributor
Author
|
alrighty!!!!! |
corp-0
approved these changes
Mar 30, 2025
Member
corp-0
left a comment
corp-0
left a comment
There was a problem hiding this comment.
Code looks good. I built this and tested, it is working fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the PlayerCountMax Entry in the Server API.
Closes #237.