Skip to content

Fix externally created MQTT client usage (#fixes #331). #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kratz00
Copy link
Collaborator

@kratz00 kratz00 commented Mar 18, 2025

Table of Contents generated with DocToc

Description

License Acceptance

  • This repository is Apache version 2.0 licensed and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Type of changes

  • Add/update a helper script
  • Add/update link to an external resource like a blog post or video
  • Bug fix
  • New feature
  • Test updates
  • Text cleanups/updates

Checklist

  • I have read the CONTRIBUTING document.
  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
  • Scripts added/updated in this PR are all marked executable.
  • Scripts added/updated in this PR do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that any links added or updated in my PR are valid.

@unixorn
Copy link
Owner

unixorn commented Apr 16, 2025

Please include a pydantic update to address @unl0ck's comments in #333

I haven't been doing much work on the repo lately and don't want to interfere with your work.

Then when this gets merged, I'll release 0.19.0

@kratz00
Copy link
Collaborator Author

kratz00 commented Apr 16, 2025

@unixorn The pydantic update is already in main, if you like you can already release as is, do not wait for this PR, I will be enjoying the Easter holidays now.

@unixorn
Copy link
Owner

unixorn commented Apr 17, 2025

Oh nice! Enjoy the holiday - I should have been more clear that I just wanted it rolled in, not that I wanted it on a specific schedule.

I've been busy with work and not able to give it much attention, so I really appreciate all the work you've been doing on this project.

@unixorn unixorn mentioned this pull request Apr 17, 2025
@unixorn unixorn added the enhancement New feature or request label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants