Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: implement with unjs template #9

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nozomuikuta
Copy link

@nozomuikuta nozomuikuta commented Jan 19, 2023

No related PRs.

I applied unjs/template to this repository.

⚠️ This PR includes breaking changes:

  • Use named export instead of default export

Please close this PR with a message if it is not needed to "unjs-nize" the repository, or is there any other way I can contribute?

@nozomuikuta nozomuikuta self-assigned this Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

package.json Outdated
Comment on lines 6 to 8
"contributors": [
"Nozomu Ikuta <[email protected]>"
],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, only if you are fine.

@nozomuikuta
Copy link
Author

nozomuikuta commented Jan 24, 2023

📝 Applied unjs/template (until 070b86f)

@nozomuikuta nozomuikuta requested a review from pi0 January 24, 2023 08:36
@dargmuesli
Copy link

@pi0 what's the status on this? :)

@nozomuikuta
Copy link
Author

Oh, this PR slipped even my mind.
More than half a year has passed, so I might want to update it with the latest template if needed and if "unjs-nization" is accepted in the first place.

@nozomuikuta
Copy link
Author

nozomuikuta commented Sep 26, 2023

Updated with the latest unjs template
https://github.com/unjs/template/tree/9d3de16836c2cbd73c093036f0685a496dd6faf0

Note that I intentionally excluded playground-related part of the template, because this repository would not need it.

CHANGELOG.md Outdated
@@ -1,49 +0,0 @@
# Changelog

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the CHANGELOG be removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't mean to delete it, thank you for pointing it out!
Reverted: 103d45c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants