feat(subcommand): support alias for subcommand #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
reviewed
Mar 9, 2025
| @@ -90,6 +90,7 @@ export type SubCommandsDef = Record<string, Resolvable<CommandDef<any>>>; | |||
| export type CommandDef<T extends ArgsDef = ArgsDef> = { | |||
| meta?: Resolvable<CommandMeta>; | |||
| args?: Resolvable<T>; | |||
| alias?: Resolvable<string | string[]>; | |||
There was a problem hiding this comment.
minor nit, maybe this should actually be in a SubCommandDef
you can't alias the root command since it is the 'argless' execution afaict
so maybe SubCommandsDef should actually be Record<string, Resolvable<SubCommandDef<any>>>, where SubCommandDef is just CommandDef<T> & {alias?: Resolvable<string | string[]>}
what do you think?
There was a problem hiding this comment.
Thank you for your review, this is an early PR, it took me some time to understand it.😂
I agree with you and I will try to revise it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support alias for subCommand
Resolved: #152