Skip to content

refactor: improve usage tips #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 37 additions & 21 deletions src/usage.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import consola from "consola";
import { colors } from "consola/utils";
import { snakeCase } from "scule";
import { formatLineColumns, resolveValue } from "./_utils";
import type { ArgsDef, CommandDef } from "./types";
import type { Arg, ArgsDef, CommandDef } from "./types";
import { resolveArgs } from "./args";

export async function showUsage<T extends ArgsDef = ArgsDef>(
Expand Down Expand Up @@ -39,30 +40,17 @@ export async function renderUsage<T extends ArgsDef = ArgsDef>(
if (arg.type === "positional") {
const name = arg.name.toUpperCase();
const isRequired = arg.required !== false && arg.default === undefined;
// (isRequired ? " (required)" : " (optional)"
const defaultHint = arg.default ? `="${arg.default}"` : "";
posLines.push([
"`" + name + defaultHint + "`",
arg.description || "",
arg.valueHint ? `<${arg.valueHint}>` : "",
"`" + name + renderValueHint(arg) + "`",
renderDescription(arg, isRequired),
]);
usageLine.push(isRequired ? `<${name}>` : `[${name}]`);
} else {
const isRequired = arg.required === true && arg.default === undefined;
const argStr =
[...(arg.alias || []).map((a) => `-${a}`), `--${arg.name}`].join(", ") +
(arg.type === "string" && (arg.valueHint || arg.default)
? `=${
arg.valueHint ? `<${arg.valueHint}>` : `"${arg.default || ""}"`
}`
: "") +
(arg.type === "enum" && arg.options
? `=<${arg.options.join("|")}>`
: "");
argLines.push([
"`" + argStr + (isRequired ? " (required)" : "") + "`",
arg.description || "",
]);
renderValueHint(arg);
argLines.push(["`" + argStr + "`", renderDescription(arg, isRequired)]);

/**
* print negative boolean arg variant usage when
Expand All @@ -79,13 +67,15 @@ export async function renderUsage<T extends ArgsDef = ArgsDef>(
`--no-${arg.name}`,
].join(", ");
argLines.push([
"`" + negativeArgStr + (isRequired ? " (required)" : "") + "`",
arg.negativeDescription || "",
"`" + negativeArgStr + "`",
[arg.negativeDescription, isRequired ? colors.gray("(Required)") : ""]
.filter(Boolean)
.join(" "),
]);
}

if (isRequired) {
usageLine.push(argStr);
usageLine.push(`--${arg.name}` + renderValueHint(arg));
}
}
}
Expand Down Expand Up @@ -149,3 +139,29 @@ export async function renderUsage<T extends ArgsDef = ArgsDef>(

return usageLines.filter((l) => typeof l === "string").join("\n");
}

function renderValueHint(arg: Arg) {
const valueHint = arg.valueHint ? `=<${arg.valueHint}>` : "";
const fallbackValueHint = valueHint || `=<${snakeCase(arg.name)}>`;

if (!arg.type || arg.type === "positional" || arg.type === "boolean") {
return valueHint;
}

if (arg.type === "enum" && arg.options?.length) {
return `=<${arg.options.join("|")}>`;
}

return fallbackValueHint;
}

function renderDescription(arg: Arg, required: boolean) {
const requiredHint = required ? colors.gray("(Required)") : "";
const defaultHint =
arg.default === undefined ? "" : colors.gray(`(Default: ${arg.default})`);
const description = [arg.description, requiredHint, defaultHint]
.filter(Boolean)
.join(" ");

return description;
}
22 changes: 11 additions & 11 deletions test/usage.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,18 @@ describe("usage", () => {
expect(usage).toMatchInlineSnapshot(`
"A command (Commander)

USAGE \`Commander [OPTIONS] --foo <POS>\`
USAGE \`Commander [OPTIONS] --foo=<foo> <POS>\`

ARGUMENTS

\`POS\` A pos
\`POS\` A pos (Required)

OPTIONS

\`--foo (required)\` A foo
\`-b, --bar\` A bar
\`--enum=<a|b>\` An enum
\`--boolean\` A boolean
\`--foo=<foo>\` A foo (Required)
\`-b, --bar=<bar>\` A bar
\`--enum=<a|b>\` An enum
\`--boolean\` A boolean
"
`);
});
Expand Down Expand Up @@ -100,8 +100,8 @@ describe("usage", () => {

OPTIONS

\`--boolean\` A boolean
\`--no-boolean\` A negative boolean
\`--boolean\` A boolean (Default: true)
\`--no-boolean\` A negative boolean
"
`);
});
Expand Down Expand Up @@ -159,7 +159,7 @@ describe("usage", () => {

OPTIONS

\`--foo="bar"\` A foo
\`--foo=<foo>\` A foo (Default: bar)
"
`);
});
Expand Down Expand Up @@ -226,7 +226,7 @@ describe("usage", () => {

OPTIONS

\`--foo (required)\` A foo
\`--foo\` A foo (Required)

COMMANDS

Expand Down Expand Up @@ -309,7 +309,7 @@ describe("usage", () => {

OPTIONS

\`--foo\` A foo
\`--foo=<foo>\` A foo

COMMANDS

Expand Down