Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Chinese translations #341

Closed
wants to merge 15 commits into from
Closed

Conversation

AllenYu0118
Copy link

πŸ”— Linked issue

#340

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Close #340

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

@BabyLy233 BabyLy233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix typo

δ½™η£Š added 2 commits December 12, 2023 21:09
@pi0 pi0 requested a review from antfu December 12, 2023 17:10
@antfu
Copy link
Member

antfu commented Dec 12, 2023

I am not so sure if we want to maintain translations for docs, given the fact that:

  • We duplicate the sources of truth. Every time we update something, we need to spend extra effort updating translations or we create misalignment
  • ofetch is not a very user-facing library I suppose?
  • AI nowadays could provide very accurate translations already

@pi0
Copy link
Member

pi0 commented Dec 12, 2023

Thanks for PR dear @AllenYu0118 and willing to help on translations. I think @antfu is correct as keeping the docs up to date can be challenging in the future. We might think of automated translations in website in the future. I have moved the follow to this thread: unjs/website#207

@AllenYu0118
Copy link
Author

I agree with your idea, thank for your response.πŸ€”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I want to provide a Chinese README file, is it feasible?
4 participants