fix(cache): isolate cache keys per provider name and options #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushichan044
changed the title
sushichan044
changed the title
sushichan044
commented
Nov 10, 2025
sushichan044
force-pushed
the
sushichan044-202511081110-provider-aware
branch
from
85c0863 to
fa869d3
Compare
sushichan044
force-pushed
the
sushichan044-202511081110-provider-aware
branch
from
cb6bacd to
d30e722
Compare
sushichan044
changed the title
sushichan044
changed the title
sushichan044
force-pushed
the
sushichan044-202511081110-provider-aware
branch
from
0966299 to
f10ed13
Compare
sushichan044
commented
Nov 20, 2025
src/cache.ts
Outdated
Comment on lines
75
to
76
| // No hash for string parts for better readability. | ||
| const part = typeof f === 'string' ? f : hash(f) |
Contributor
Author
There was a problem hiding this comment.
For example, if we also hash values like the font provider’s name, it becomes difficult to identify files when checking what Storage has saved. So I think we shouldn’t hash string fields.
sushichan044
force-pushed
the
sushichan044-202511081110-provider-aware
branch
from
e1d8f29 to
9f764a1
Compare
Contributor
Author
|
@danielroe |
Contributor
Author
|
Since the commit history became too cluttered and conflicted with other PRs, I used a force push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #184
This PR updates the cache storage generation to automatically include the provider name and options in the cache key.
Users don’t need to do anything special when defining a provider.
Additional Context
Purpose 1 of #239 (comment).