Skip to content

Bump GCC version in build.yml to 14 #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurynas-biveinis merged 1 commit into from
Nov 14, 2025
Merged

Bump GCC version in build.yml to 14 #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,66 +36,66 @@ jobs:
fail-fast: false
matrix:
include:
- name: GCC 13 Release
- name: GCC 14 Release
os: ubuntu-latest
BUILD_TYPE: Release
COMPILER: gcc

- name: GCC 13 Release with ASan
- name: GCC 14 Release with ASan
os: ubuntu-latest
BUILD_TYPE: Release
COMPILER: gcc
SANITIZE_ADDRESS: ON

- name: GCC 13 Release with TSan
- name: GCC 14 Release with TSan
os: ubuntu-latest
BUILD_TYPE: Release
COMPILER: gcc
SANITIZE_THREAD: ON

- name: GCC 13 Release with UBSan
- name: GCC 14 Release with UBSan
os: ubuntu-latest
BUILD_TYPE: Release
COMPILER: gcc
SANITIZE_UB: ON

- name: GCC 13 Debug
- name: GCC 14 Debug
os: ubuntu-latest
BUILD_TYPE: Debug
COMPILER: gcc

- name: GCC 13 Debug with ASan
- name: GCC 14 Debug with ASan
os: ubuntu-latest
BUILD_TYPE: Debug
COMPILER: gcc
SANITIZE_ADDRESS: ON

- name: GCC 13 Debug with TSan
- name: GCC 14 Debug with TSan
os: ubuntu-latest
BUILD_TYPE: Debug
COMPILER: gcc
SANITIZE_THREAD: ON

- name: GCC 13 Debug with UBSan
- name: GCC 14 Debug with UBSan
os: ubuntu-latest
BUILD_TYPE: Debug
COMPILER: gcc
SANITIZE_UB: ON

- name: GCC 13 Debug without AVX2
- name: GCC 14 Debug without AVX2
os: ubuntu-latest
BUILD_TYPE: Debug
COMPILER: gcc
AVX2: OFF

- name: GCC 13 Release static analysis & cpplint
- name: GCC 14 Release static analysis & cpplint
os: ubuntu-latest
BUILD_TYPE: Release
COMPILER: gcc
STATIC_ANALYSIS: ON
CPPLINT: ON

- name: GCC 13 default CMake configuration
- name: GCC 14 default CMake configuration
os: ubuntu-latest
COMPILER: gcc

Expand Down Expand Up @@ -285,7 +285,7 @@ jobs:

- name: Setup dependencies for GCC
run: |
sudo apt-get install -y g++-13 g++-13-multilib
sudo apt-get install -y g++-14 g++-14-multilib
if: runner.os == 'Linux' && env.COMPILER == 'gcc'

- name: Setup dependencies for Linux LLVM (common)
Expand Down Expand Up @@ -343,7 +343,7 @@ jobs:
CBT=""
fi
if [[ $COMPILER == "gcc" ]]; then
V=13
V=14
EXTRA_CMAKE_ARGS=()
export CC=gcc-$V
export CXX=g++-$V
Expand Down
65 changes: 65 additions & 0 deletions .github/workflows/old-compilers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,64 @@ jobs:
VERSION: 12
STATS: OFF

- name: GCC 13 Release
BUILD_TYPE: Release
COMPILER: gcc
VERSION: 13
STATS: OFF
BOOST: OFF

- name: GCC 13 Release with ASan
BUILD_TYPE: Release
SANITIZE_ADDRESS: ON
COMPILER: gcc
VERSION: 13
STATS: OFF

- name: GCC 13 Release with TSan
BUILD_TYPE: Release
SANITIZE_THREAD: ON
COMPILER: gcc
VERSION: 13
STATS: OFF
BOOST: OFF

- name: GCC 13 Release with UBSan
BUILD_TYPE: Release
SANITIZE_UB: ON
COMPILER: gcc
VERSION: 13
STATS: OFF

- name: GCC 13 Debug
BUILD_TYPE: Debug
COMPILER: gcc
VERSION: 13
STATS: OFF
BOOST: OFF

- name: GCC 13 Debug with ASan
BUILD_TYPE: Debug
SANITIZE_ADDRESS: ON
COMPILER: gcc
VERSION: 13
STATS: OFF

- name: GCC 13 Debug with TSan
BUILD_TYPE: Debug
SANITIZE_THREAD: ON
COMPILER: gcc
VERSION: 13
STATS: OFF
BOOST: OFF

- name: GCC 13 Debug with UBSan
BUILD_TYPE: Debug
SANITIZE_UB: ON
COMPILER: gcc
VERSION: 13
STATS: OFF

steps:
- uses: actions/checkout@v5
with:
Expand Down Expand Up @@ -669,6 +727,13 @@ jobs:
sudo apt-get install -y gcc
if: env.COMPILER == 'gcc' && env.VERSION == '11'

- name: Setup dependencies for GCC 13 (PPA)
run: |
sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt-get update
sudo apt-get install -y g++-13
if: env.COMPILER == 'gcc' && env.VERSION == '13'
Comment on lines +730 to +735
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Missing multilib package for GCC 13 installation.

The PPA setup installs only g++-13, but .github/workflows/build.yml line 288 installs g++-14 g++-14-multilib. For consistency and to ensure proper multilib support (needed for 32-bit compilation), install g++-13-multilib as well.

      - name: Setup dependencies for GCC 13 (PPA)
        run: |
          sudo add-apt-repository ppa:ubuntu-toolchain-r/test
          sudo apt-get update
-         sudo apt-get install -y g++-13
+         sudo apt-get install -y g++-13 g++-13-multilib
        if: env.COMPILER == 'gcc' && env.VERSION == '13'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Setup dependencies for GCC 13 (PPA)
run: |
sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt-get update
sudo apt-get install -y g++-13
if: env.COMPILER == 'gcc' && env.VERSION == '13'
- name: Setup dependencies for GCC 13 (PPA)
run: |
sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt-get update
sudo apt-get install -y g++-13 g++-13-multilib
if: env.COMPILER == 'gcc' && env.VERSION == '13'
🤖 Prompt for AI Agents 
In .github/workflows/old-compilers.yml around lines 730 to 735, the GCC 13 PPA
step installs only g++-13 but omits the multilib package; update the apt-get
install command to include g++-13-multilib so the step installs both g++-13 and
g++-13-multilib (matching the pattern used for GCC 14) to enable 32-bit/multilib
builds.


- name: Configure CMake
# Use a bash shell so we can use the same syntax for environment
# variable access regardless of the host operating system
Expand Down
Loading