Add GCC 15 support, excluding CI#803
Conversation
- Fix a build warning - Bump GCC version in CMakePresets.json CI is excluded because of no simple way to get GCC 15 on Ubuntu 24.04 (or 22.04)
WalkthroughVersion bump for GCC compiler targets from 14 to 15 in build configuration, and simplification of a test parameter by removing an unnecessary explicit cast from the bitwise complement operation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Both changes are straightforward—one is a direct version increment in configuration, the other is a redundant cast removal that doesn't alter test semantics. Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
CMakePresets.json(1 hunks)test/test_key_encode_decode.cpp(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
test/test_key_encode_decode.cpp (1)
351-351: LGTM! Removes redundant cast for uint64_t.The removal of
static_cast<T>where T isstd::uint64_tis correct. Since~0ULLalready has typeunsigned long long(typically 64 bits), casting it touint64_tis redundant when they're the same size. This properly addresses the GCC 15 warning mentioned in the PR description.Note that similar casts at lines 199, 247, and 297 are retained correctly because they perform actual narrowing conversions for smaller types (uint8_t, uint16_t, uint32_t).
|



CI is excluded because of no simple way to get GCC 15 on Ubuntu 24.04 (or 22.04)
Summary by CodeRabbit
Chores
Tests