Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Unskip Basics_AutomatedTransformation on Android #13061

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 30, 2023

GitHub Issue (If applicable): #9080

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Test is failing on Android. The reason is that SUT already has a parent, and then we try to set it to ContentControl.Content. The test actually already fails on Windows, so I didn't attempt to gracefully handle this case in ContentControl.RegisterContentTemplateRoot.

What is the new behavior?

A little test hack to remove the parent to allow the test to run successfully.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Sorry, something went wrong.

@Youssef1313 Youssef1313 force-pushed the fix-test-Basics_AutomatedTransformation branch from 3a17e06 to 3aa0311 Compare July 30, 2023 17:10
@agneszitte agneszitte merged commit 13a6add into unoplatform:master Jul 31, 2023
@Youssef1313 Youssef1313 deleted the fix-test-Basics_AutomatedTransformation branch July 31, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants