fix: ios PasswordBox changed event when focus #19337
Open
+43
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/ios 🍎
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19337/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19337/index.html |
Xiaoy312
reviewed
Mar 17, 2025
| @@ -19,10 +20,10 @@ namespace Microsoft.UI.Xaml.Controls | |||
| { | |||
| public partial class SinglelineTextBoxView : UITextField, ITextBoxView, DependencyObject, IFontScalable | |||
| { | |||
| private SinglelineTextBoxDelegate _delegate; | |||
| private SinglelineTextBoxDelegate _delegate = null!; | |||
There was a problem hiding this comment.
Suggested change
| private SinglelineTextBoxDelegate _delegate = null!; | |
| private SinglelineTextBoxDelegate _delegate; |
and tag Initialize() with [MemberNotNull(nameof(_delegate))]
Comment on lines
+115
to
125
| if (SecureTextEntry && !string.IsNullOrEmpty(Text)) | ||
| { | ||
| UnsubscribeEditingEvents(); | ||
|
|
||
| var text = Text; | ||
| Text = string.Empty; | ||
| UpdatePasswordText(string.Empty); | ||
| InsertText(text); | ||
| UpdatePasswordText(text); | ||
|
|
||
| SubscribeEditingEvents(); | ||
| } |
There was a problem hiding this comment.
wouldnt it be better to use a flag to guard the handlers, instead of un- and re-registering the events?
| @@ -54,7 +55,7 @@ private void HandlePaste(Action baseAction) | |||
|
|
|||
| internal TextBox TextBox => _textBox.GetTarget(); | |||
There was a problem hiding this comment.
Suggested change
| internal TextBox TextBox => _textBox.GetTarget(); | |
| internal TextBox? TextBox => _textBox.GetTarget(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
PasswordBox, when unfocused and focused, sends a TextChanged event.
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):