fix: android PhoneCallManager #19638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/android 🤖
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19638/index.html |
|
The build 156963 found UI Test snapshots differences: Details
|
kazo0
reviewed
Mar 12, 2025
| #pragma warning disable CS0618 // TelephonyManager is obsolete in API 31 | ||
| #pragma warning disable CA1422 // Validate platform compatibility | ||
| _telephonyManager.Listen(new CallStateListener(), PhoneStateListenerFlags.CallState); | ||
| if (await Extensions.PermissionsHelper.CheckPermission(CancellationToken.None, Android.Manifest.Permission.ReadPhoneState) || |
There was a problem hiding this comment.
we should only need the TryGetPermission call here. It will return true if the permission has already been granted
There was a problem hiding this comment.
should we add an exception if the permission isn't allowed? like this
uno/src/Uno.UWP/Media/SpeechRecognition/SpeechRecognizer.Android.cs
Lines 24 to 27 in f8382a2
rajamatt
force-pushed
the
dev/mara/fix-calls
branch
from
a076b27 to
e9a2569
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19638/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19638/index.html |
|
The build 157483 found UI Test snapshots differences: Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #19633
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Telephony.Listen is deprecated for API >= 31, it causes a SecurityException now.
What is the new behavior?
Now we use Telephony.Listen if API < 31 and Telephony.RegisterTelephonyCallback if API >= 31. We also check the READ_PHONE_STATE permission that's required for this new method.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):