Skip to content

Conversation

ValwareIRC
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 10:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates multiple UnrealIRCd modules to be compatible with version 6.2, updating minimum version requirements and adjusting function signatures to match the new API.

  • Updated minimum UnrealIRCd version requirement from "6.*" to "6.2" across all modules
  • Updated function signatures to include new ClientContext parameter for message hooks
  • Replaced deprecated CallCommandOverride with CALL_NEXT_COMMAND_OVERRIDE macro

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
files/reduced-moderation.c Updated version requirements and function signature for channel message hook
files/nicklock.c Updated version requirements and command override call
files/mute.c Updated version requirements and message hook function signatures
files/lockserv.c Updated version requirements and replaced command override macro
files/elmer.c Updated version requirements and message hook function signatures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@syzop
Copy link
Member

syzop commented Sep 8, 2025

Could you change the PR with some #if's to allow both UnrealIRCd 6.2.x and older?

Right now if i would merge this PR then nobody would be able to install these modules on 6.1.10 anymore.

@syzop
Copy link
Member

syzop commented Sep 8, 2025

You can use:

#if UNREAL_VERSION >= 0x06020000
... do the UnrealIRCd 6.2.x stuff...
#else
...do the UnrealIRCd 6.0.x/6.1.x stuff...
#endif

You can use that construct in your elmer.c, mute.c and reduced-moderation.c.

The lockserv.c only needed the CALL_NEXT_COMMAND_OVERRIDE() which works for 6.0.x/6.1.x/6.2.x (you already did that).

For nicklock.c I see you didn't use CALL_NEXT_COMMAND_OVERRIDE() but you can use that there too, unless i mised something. Makes things easy since it works on all versions.

And then for all 5 modules change the min version back to 6, like min-unrealircd-version "6.*";

@syzop syzop merged commit 6b34ce9 into unrealircd:unreal6 Sep 10, 2025
@syzop
Copy link
Member

syzop commented Sep 10, 2025

Merged mostly without checking. Thanks! Hope more module authors will follow :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants