Conversation
jimini1026
requested changes
May 23, 2024
Contributor
jimini1026
left a comment
jimini1026
left a comment
There was a problem hiding this comment.
엄청 잘하고 있어요😎
아직 수정할 부분이 조금 있어서 일단 reject 시켜놓을게여!
assets/modal/modal.html
Outdated
Comment on lines
+13
to
+15
| <li><img src="../img/setting_img.png"> 초기 설정값을 확인해 주세요</li> | ||
| <li><img src="../img/bell_img.png"> 처음 설치 시 알람이 뜰 수 있음을 유의해 주세요</li> <!--css에서 옆으로 밀면 될것같은데..--> | ||
| <li><img src="../img/warning_img.png"> 본 프로그램으로 생기는 불이익은 책임지기 힘듭니다</li> |
Contributor
There was a problem hiding this comment.
img는 닫힌 태그가 없는 태그여서 <img ~ /> 이렇게 표시해주면 더 좋아요!
assets/modal/modal.html
Outdated
| <div class="commentbox"> | ||
| <ul> | ||
| <li><img src="../img/setting_img.png"> 초기 설정값을 확인해 주세요</li> | ||
| <li><img src="../img/bell_img.png"> 처음 설치 시 알람이 뜰 수 있음을 유의해 주세요</li> <!--css에서 옆으로 밀면 될것같은데..--> |
Contributor
There was a problem hiding this comment.
주석에 적은 것 처럼   여러개로 하는 것 보단 css로 처리하는게 더 유지 보수나 개발 면에서도 편리해서 조금 더 공부해보면서 시도해보면 좋을 거 같아요!
1학년인데 이정도면 엄청 잘하고 있는겁니닷
Contributor
There was a problem hiding this comment.
Flex, grid에 대해서 공부해보면 좋을거 같슴다
assets/modal/modal.html
Outdated
| </ul> | ||
| </div> | ||
| <div class="error-imform"> | ||
| <div class=""> |
Contributor
There was a problem hiding this comment.
class 명이 없는 상태로 커밋이 되었어요..!
jimini1026
requested changes
May 25, 2024
Contributor
jimini1026
left a comment
jimini1026
left a comment
There was a problem hiding this comment.
코멘트 참고해주세요
상위 15%입니다. 👍
assets/modal/modal.css
Outdated
Comment on lines
+11
to
+17
| h2 { | ||
| text-align: top; | ||
| vertical-align: top; | ||
| } | ||
| img { | ||
| width: 57px; | ||
| } |
Contributor
There was a problem hiding this comment.
h2, img 같은 태그는 공용적으로 사용되는 태그이므로 해당 부분에 클래스나 아이디를 붙여서 css 속성을 부여해주세요!
assets/modal/modal.html
Outdated
Comment on lines
+10
to
+14
| <h2><img src="../img/iconImg-1.png"> Comboong Note</h2> | ||
| <div class="commentbox"> | ||
| <ul> | ||
| <li><img src="../img/setting_img.png"> 초기 설정값을 확인해 주세요</li> | ||
| <li><img src="../img/bell_img.png"> 처음 설치 시 알람이 뜰 수 있음을 유의해 주세요</li> <!--css에서 옆으로 밀면 될것같은데..--> |
Contributor
There was a problem hiding this comment.
 를 사용하는 대신 아래 링크 참고해서 css를 이용하면 좋을거 같애요
…into chore/깃허브_연습2_#18
모달창 본문
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
preview