feat: updated file-uploader to 1.19.3 #39
Conversation
WalkthroughThe changes update the Changes
Estimated code review effort1 (~7 minutes) Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (7)
examples/svelte-uploader/package.json (1)
19-21: Dependency bumped – looks goodNo other changes required. Ensure the lock-file is updated.
examples/js-custom-tab/package.json (1)
17-19: Dependency bumped – looks goodSame note about lock-file regeneration.
examples/react-uploader/package.json (1)
12-14: Dependency bumped – looks goodNo issues spotted. Update
package-lock.json.examples/next-uploader/package.json (1)
11-11: Same action needed as noted for Angular exampleRegenerate the lockfile and smoke-test the example to ensure the new uploader works with Next 13.
examples/vue-uploader/package.json (1)
13-13: Same action needed as noted for Angular exampleRegenerate the lockfile and smoke-test the example to ensure the new uploader works with Vue 3.
examples/react-uploader-adapter/package.json (1)
13-13: Same action needed as noted for Angular exampleRegenerate the lockfile and smoke-test the example to ensure the new uploader and
@uploadcare/react-uploaderintegrate correctly.examples/next-uploader-adapter/package.json (1)
11-11: Same action needed as noted for Angular exampleRegenerate the lockfile and smoke-test the example to ensure the new uploader works with Next 14.
🧹 Nitpick comments (1)
package.json (1)
7-7:install-depsscript installs only one package – likely insufficientThe previous version of this script installed all dependencies for each example.
After the change it installs only@uploadcare/file-uploader, leaving the rest of the declared deps un-installed for local dev. Unless that is intentional, this will breaknpm start / buildin every example that relies on other packages.Consider reverting to a full
npm i/npm ci, or run both commands:-"install-deps": "for dir in ./examples/*; do npm i @uploadcare/file-uploader --prefix \"${dir}\"; done", +"install-deps": "for dir in ./examples/*; do npm i --prefix \"${dir}\"; npm i @uploadcare/file-uploader@^1.19.3 --prefix \"${dir}\"; done",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (11)
examples/angular-uploader/package-lock.jsonis excluded by!**/package-lock.jsonexamples/js-custom-tab/package-lock.jsonis excluded by!**/package-lock.jsonexamples/js-uploader/package-lock.jsonis excluded by!**/package-lock.jsonexamples/js-uploader/yarn.lockis excluded by!**/yarn.lock,!**/*.lockexamples/next-uploader-adapter/package-lock.jsonis excluded by!**/package-lock.jsonexamples/next-uploader/package-lock.jsonis excluded by!**/package-lock.jsonexamples/react-uploader-adapter/package-lock.jsonis excluded by!**/package-lock.jsonexamples/react-uploader/package-lock.jsonis excluded by!**/package-lock.jsonexamples/svelte-uploader/package-lock.jsonis excluded by!**/package-lock.jsonexamples/vue-uploader/package-lock.jsonis excluded by!**/package-lock.jsonpackage-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (12)
examples/angular-uploader/package.json(1 hunks)examples/angular-uploader/src/app/views/regular-view/regular-view.component.html(2 hunks)examples/angular-uploader/tsconfig.json(1 hunks)examples/js-custom-tab/package.json(1 hunks)examples/js-uploader/package.json(1 hunks)examples/next-uploader-adapter/package.json(1 hunks)examples/next-uploader/package.json(1 hunks)examples/react-uploader-adapter/package.json(1 hunks)examples/react-uploader/package.json(1 hunks)examples/svelte-uploader/package.json(1 hunks)examples/vue-uploader/package.json(1 hunks)package.json(1 hunks)
🔇 Additional comments (5)
examples/js-uploader/package.json (1)
11-13: Version bump LGTM
@uploadcare/file-uploader^1.19.3 matches the PR goal and has no breaking API changes between 1.2.x → 1.19.x.
Remember to regenerate/commit thepackage-lock.jsonso CI picks the right version.examples/angular-uploader/package.json (1)
20-20: Confirm compatibility with v17 and refresh example’s lockfileThe automated smoke-test in our sandbox failed due to missing local CLIs (ng, vite, next, etc.). Please:
- In examples/angular-uploader:
- Run
npm installto update its package-lock.json (or yarn.lock).- Commit the refreshed lockfile.
- On a machine with the Angular CLI installed, verify the Angular wrapper builds and runs against
@uploadcare/file-uploader@^1.19.3(v17):cd examples/angular-uploader npm install npm run build- Ensure no breaking changes and the app still compiles/runs as expected.
examples/angular-uploader/tsconfig.json (1)
21-21: Cosmetic formatting change is fineThe switch to a single-line array does not affect compilation and keeps the configuration concise.
examples/angular-uploader/src/app/views/regular-view/regular-view.component.html (2)
6-6: Confirm that collapsing the component tag is safeMoving the opening/closing pair to a single line is purely stylistic, provided the component never expected projected content between its tags. Double-check that no projected content has been removed in earlier revisions.
30-30: Indentation tweak improves readabilityIndentation is now consistent with surrounding markup.
| "dependencies": { | ||
| "install-deps": "^1.1.0" | ||
| } |
There was a problem hiding this comment.
Suspicious new runtime dependency install-deps
Adding a package called install-deps looks accidental:
- It shares the same name as your script, increasing confusion.
- The package exists on NPM but is abandoned (last published 2017) and pulls in
babel-core@6, which is vulnerable.
Unless you explicitly need this library at runtime, remove it or move it to devDependencies.
- "dependencies": {
- "install-deps": "^1.1.0"
- }
+ "devDependencies": {}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "dependencies": { | |
| "install-deps": "^1.1.0" | |
| } | |
| "devDependencies": {} |
🤖 Prompt for AI Agents
In package.json around lines 13 to 15, the dependency "install-deps" is added as
a runtime dependency but appears to be unnecessary and outdated with
vulnerabilities. Remove "install-deps" from the "dependencies" section and if it
is needed only for development or build purposes, move it to the
"devDependencies" section instead.
1 participant
Description
Checklist
Summary by CodeRabbit