Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename field value to default value #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: rename field value to default value #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/uploader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
{
id,
name,
value,
value, // @deprecated
defaultValue,
onFileSelect,
onChange,
onDialogOpen,
Expand Down Expand Up @@ -167,11 +168,11 @@
}, [widgetOptions])

useEffect(() => {
if (cachedValueRef.current !== value) {
widget.current.value(value)
if (cachedValueRef.current !== defaultValue) {
widget.current.value(defaultValue)
}
cachedValueRef.current = value
}, [value])
cachedValueRef.current = defaultValue
}, [])

Check warning on line 175 in src/uploader.js

View workflow job for this annotation

GitHub Actions / build 

React Hook useEffect has a missing dependency: 'defaultValue'. Either include it or remove the dependency array

useEffect(() => {
if (uploadcare && tabsCss && typeof tabsCss === 'string') {
Expand Down
Loading