Merge 4.4.0 release to main #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if an error from the API was returned while polling for updates on a file, it would continue polling. I updated it so that it raises a RequestError if the API returns an error status. If not, it raises a RetryError, which is swallowed by the retry gem's `with_retries` block.
Example of an error that led to continued polling:
```
{"status":"error","error":"File validation error: Uploading of these file types is not allowed.","error_code":"DownloadFileValidationFailedError"}
```
Fix namespace for service Add spec for upload_from_url Fix requiring of SignatureGenerator and location of tests
vipulnsward
force-pushed
the
4.4.0-commits
branch
from
7eba0c2 to
931d8fa
Compare
vipulnsward
commented
Mar 9, 2024
| @@ -2,106 +2,131 @@ | |||
|
|
|||
| require 'spec_helper' | |||
|
|
|||
| module Uploadcare | |||
There was a problem hiding this comment.
These are mostly whitespace changes. Better diff view available here: https://github.com/uploadcare/uploadcare-ruby/pull/156/files?diff=split&w=1#diff-927717518ecbedcd1649c3a325798166ecf1e10b4736a26820fb09170f211505
rsedykh
approved these changes
Mar 9, 2024
Co-authored-by: Roman Sedykh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist