Add new AuthError class for raising authentication related issues when public/private keys are empty. Closes #158

CHANGELOG.md

@@ -5,6 +5,12 @@
 ### Changed
 * File attribute `datetime_stored` is deprecated and will warn on usage from `File` object properties.
 
+## Unreleased
+
+### Fixed
+
+* Throw `AuthError` if current public key or secret key config are empty when accessing any of the APIs. 
+
 ## 4.4.0 — 2024-03-09
 
 ### Breaking

lib/uploadcare.rb

@@ -7,6 +7,7 @@
 require 'exception/throttle_error'
 require 'exception/request_error'
 require 'exception/retry_error'
+require 'exception/auth_error'
 
 # Entities
 require 'entity/entity'

lib/uploadcare/exception/auth_error.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+module Uploadcare
+  module Exception
+    # Invalid Auth configuration error
+    class AuthError < StandardError; end
+  end
+end

lib/uploadcare/param/authentication_header.rb

@@ -11,6 +11,7 @@ module Param
     class AuthenticationHeader
       # @see https://uploadcare.com/docs/api_reference/rest/requests_auth/#auth-uploadcare
       def self.call(options = {})
+        validate_auth_config
         case Uploadcare.config.auth_type
         when 'Uploadcare'
           SecureAuthHeader.call(options)
@@ -20,6 +21,17 @@ def self.call(options = {})
           raise ArgumentError, "Unknown auth_scheme: '#{Uploadcare.config.auth_type}'"
         end
       end
+
+      def self.validate_auth_config
+        raise AuthError, 'Public Key is blank.' if is_blank?(Uploadcare.config.public_key)
+        raise AuthError, 'Secret Key is blank.' if is_blank?(Uploadcare.config.secret_key)
+      end
+
+      # rubocop:disable Naming/PredicateName
+      def self.is_blank?(value)
+        value.nil? || value.empty?
+      end
+      # rubocop:enable Naming/PredicateName
     end
   end
 end

spec/uploadcare/client/file_client_spec.rb

@@ -16,6 +16,30 @@ module Client
           end
         end
 
+        it 'show raise argument error if public_key is blank' do
+          Uploadcare.config.public_key = ''
+          VCR.use_cassette('rest_file_info') do
+            uuid = '2e17f5d1-d423-4de6-8ee5-6773cc4a7fa6'
+            expect { subject.info(uuid) }.to raise_error(AuthError, 'Public Key is blank.')
+          end
+        end
+
+        it 'show raise argument error if secret_key is blank' do
+          Uploadcare.config.secret_key = ''
+          VCR.use_cassette('rest_file_info') do
+            uuid = '2e17f5d1-d423-4de6-8ee5-6773cc4a7fa6'
+            expect { subject.info(uuid) }.to raise_error(AuthError, 'Secret Key is blank.')
+          end
+        end
+
+        it 'show raise argument error if secret_key is nil' do
+          Uploadcare.config.secret_key = nil
+          VCR.use_cassette('rest_file_info') do
+            uuid = '2e17f5d1-d423-4de6-8ee5-6773cc4a7fa6'
+            expect { subject.info(uuid) }.to raise_error(AuthError, 'Secret Key is blank.')
+          end
+        end
+
         it 'supports extra params like include' do
           VCR.use_cassette('rest_file_info') do
             uuid = '640fe4b7-7352-42ca-8d87-0e4387957157'

spec/uploadcare/param/authentication_header_spec.rb

@@ -18,5 +18,15 @@ module Uploadcare
       Uploadcare.config.auth_type = 'Uploadcare'
       expect(subject.call).to eq('SecureAuth called')
     end
+
+    it 'raise argument error if public_key is blank' do
+      Uploadcare.config.public_key = ''
+      expect { subject.call }.to raise_error(AuthError, 'Public Key is blank.')
+    end
+
+    it 'raise argument error if secret_key is blank' do
+      Uploadcare.config.secret_key = ''
+      expect { subject.call }.to raise_error(AuthError, 'Secret Key is blank.')
+    end
   end
 end