Skip to content

Conversation

@xiam
Copy link
Member

@xiam xiam commented Feb 18, 2020

  • move tests under internal/tests
  • use docker-compose to spin up a server and run tests

@xiam xiam force-pushed the feature/refactor-tests branch from 215fc69 to 82e86fc Compare February 19, 2020 04:33
@xiam xiam requested a review from pkieltyka February 19, 2020 04:43
@xiam xiam force-pushed the feature/refactor-tests branch from f888490 to ba8fc2d Compare February 19, 2020 04:56
@xiam
Copy link
Member Author

xiam commented Feb 19, 2020

Hello @pkieltyka,

What do you think about moving tests to a directory?

@pkieltyka
Copy link
Member

Neat to see some clean up here :) By putting into internal folder, does that change go.mod behaviour I wonder? Looks good either way though

@xiam
Copy link
Member Author

xiam commented Feb 19, 2020 via email

@xiam
Copy link
Member Author

xiam commented Feb 19, 2020

I tried this out with https://github.com/upper/bond-example-project and didn't find anything odd with the directory change. I simulated a v0.11.0 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants