Fix gcc use-after-free false warning#131
Merged
Merged
Conversation
gcc 12 reports a use-after-free warning for this code. We believe it is a FP. More details are in #130
Collaborator
Author
|
Fails due to actions/toolkit#1890 |
Collaborator
Author
Fixed in commit #32e1c9540 (in this PR) |
Collaborator
Author
Merged
rborn-tx
approved these changes
Apr 2, 2025
Collaborator
rborn-tx
left a comment
rborn-tx
left a comment
There was a problem hiding this comment.
LGTM
The issue definitely looks like a false-positive and the fact it is solved by simply making the add_ref/release functions non-inline reinforces that hypothesis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcc 12 reports a use-after-free warning for this code. We believe it is a FP. More details are in #130