Skip to content

Fix:(issue_2254) Fix incorrect handling of arg after short option token #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dearchap wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix:(issue_2254) Fix incorrect handling of arg after short option token #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7b2800
Fix:(issue_2254) Fix incorrect handling of arg after short option token
dearchap Feb 1, 2026
a232f94
Change test name
dearchap Feb 1, 2026
b81360a
Run gofumpt
dearchap Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions command_parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ func (cmd *Command) parseFlags(args Args) (Args, error) {
return &stringSliceArgs{posArgs}, fmt.Errorf("%s%s", argumentNotProvidedErrMsg, string(c))
}
flagVal = rargs[1]
rargs = rargs[1:]
}
tracef("parseFlags (flagName %[1]q) (flagVal %[2]q)", flagName, flagVal)
if err := cmd.set(flagName, sf, flagVal); err != nil {
Expand Down
27 changes: 27 additions & 0 deletions command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1413,6 +1413,33 @@ func TestCommand_UseShortOptionAfterSliceFlag(t *testing.T) {
assert.Equal(t, expected, name)
}

func TestCommand_UseShortOptionWithArg(t *testing.T) {
var rootPath string
cmd := &Command{
UseShortOptionHandling: true,
Commands: []*Command{
{
Name: "short",
Usage: "complete a task on the list",
Arguments: []Argument{
&StringArg{Name: "root", UsageText: "Root path", Destination: &rootPath},
},
Flags: []Flag{
&BoolFlag{Name: "serve", Aliases: []string{"s"}},
&BoolFlag{Name: "option", Aliases: []string{"o"}},
&StringFlag{Name: "message", Aliases: []string{"m"}},
},
Action: func(ctx context.Context, cmd *Command) error {
return nil
},
},
},
}
err := cmd.Run(buildTestContext(t), []string{"app", "short", "-som", "hello", "/path/to/root"})
require.NoError(t, err)
require.Equal(t, "/path/to/root", rootPath)
}

func TestCommand_Float64Flag(t *testing.T) {
var meters float64

Expand Down