fix(qemu): fix terminal mess up in qemu based deployment#459
Conversation
✅ Deploy Preview for urunc canceled.
|
|
as per discussion in #440 (comment) |
|
Hi @ishaanxgupta, thanks for working on this. Also, u need to format the code with |
|
Sure @spline2hg |
|
@cmainas please have a look, the tests should pass this time |
|
Hello @ishaanxgupta , you will need to rebase over urunc's main branch so we can merge this. |
3cfa8ba to
d471664
Compare
|
Hello @ishaanxgupta , it seems there is an issue with docker. For example: |
|
@cmainas sorry, the issue is a duplicate -serial stdio flag. This PR changed qemu.go from -nographic to -display none -vga none -serial stdio -monitor null, but linux.go - MonitorCli() also appends -serial stdio -nodefaults as extra args. QEMU rejects two character devices bound to the same stdio backend. |
Yeah that is totally correct. You can remove it from Linux then. |
|
Also, please squash your commits. |
8db8c55 to
f5d1e8a
Compare
cmainas
left a comment
There was a problem hiding this comment.
Hello @ishaanxgupta ,
the changes look good. I only have a question and a rebase will be required for merging.
eb34cc0 to
671078f
Compare
|
@cmainas rebased, can we merge this now? |
|
Could you please squash your commits? One commit introduces a change that another reverts. This is not helpful for the commit history. Also, please fix the commit linter issues |
|
Sure, hopefully this is complete now 😊 |
Signed-off-by: Ishaan Gupta <ishaankone@gmail.com>
671078f to
0cec303
Compare
cmainas
left a comment
There was a problem hiding this comment.
Thank you @ishaanxgupta for the fix!
PR: #459 Signed-off-by: Ishaan Gupta <ishaankone@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
PR: #459 Signed-off-by: Ishaan Gupta <ishaankone@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Description
With QEMU, -nographic doesn’t just “disable graphics”; it also redirects the emulated VGA/serial output to the controlling terminal (stdio) and can multiplex the QEMU monitor/serial on the same stream. That output often contains control characters / escape sequences and QEMU can leave your terminal in a weird state when it exits (so you need reset / stty sane).
Replaced -nographic with:
Related issues
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).