fix(urunc config): Ensure default values for monitor configuration#829
Merged
Conversation
✅ Deploy Preview for urunc canceled.
|
cmainas
force-pushed
the
fix_def_values_LoadUruncConfig
branch
from
July 16, 2026 17:41
6eefa52 to
bc8a30f
Compare
cmainas
marked this pull request as ready for review
July 16, 2026 17:55
ananos
approved these changes
Jul 17, 2026
Make sure that the default values defined for the monitor configuration are not overwritten if the respective fields are not defined in the configuration file. PR: #829 Signed-off-by: Charalampos Mainas <cmainas@nubificus.co.uk> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
github-actions
Bot
force-pushed
the
fix_def_values_LoadUruncConfig
branch
from
July 17, 2026 02:10
bc8a30f to
0a3a86b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make sure that the default values defined for the monitor configuration are not overwritten if the respective fields are not defined in the configuration file.
Related issues
How was this tested?
Running unit tests and e2e test
LLM usage
Opus 4.8 wrote all the unit tests
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).