ASN Hex 1609.2 Signature Retention (ITSA) by Michael7371 · Pull Request #596 · usdot-jpo-ode/jpo-ode

Michael7371 · 2026-05-08T17:07:45Z

PR Details

Description

Adding signature retention to metadata.asn1 field before stripping signature header off for decoding.
Update to the outdated TMC ODE diagram based off of ODE development updates. Added additional modules and removed outdated modules.

Related Issue

N/A

Motivation and Context

Updates to the ODE that are required for the ITSA direct -> network V2X exchange work.

How Has This Been Tested?

Unit test verification
Deployment to ITSA VM and live testing with RSU data and verifying that signatures are retained in output messages.

Types of changes

Defect fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that cause existing functionality to change)

Checklist:

I have added any new packages to the sonar-scanner.properties file
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
ODE Contributing Guide
I have added tests to cover my changes.
All new and existing tests passed.

…ctor UdpHexDecoder to extract and log untrimmed payload hex

….1 strings end with expected values across multiple receiver test classes.

…o-commit interval and add fetch-max-wait, retries, and linger.ms properties.

…type and improve packet description for troubleshooting.

dan-du-car · 2026-05-12T17:52:54Z

@@ -1,16 +1,14 @@
 /*******************************************************************************
 * Copyright 2018 572682


Year needs to be updated.

nitpick: also the copyright holder is named USDOT not 572682

@dan-du-car @iyourshaw I agree with these comments, but the cause of this issue is out of scope for this PR. A complete solution to the issue being raised would require a standalone PR to address across the codebase.
I will update this PR to remove the autoformatting changes to these sections, but don't plan to address this problem in this PR.

@dan-du-car same response as in this comment

dan-du-car · 2026-05-12T17:54:30Z

+    int off = packet.getOffset();
+    byte[] data = packet.getData();
+    // int end = Math.min(off + len, data.length);
+    // int actualLen = Math.max(0, end - off);


remove commented out code

This is resolved now.

dan-du-car · 2026-05-12T17:56:10Z

    consumer:
      enable-auto-commit: true
-      auto-commit-interval: 1000
+      auto-commit-interval: 100


can this interval be configurable? Is 100 the best choice?

This was for optimizing message latency and I agree that it should be configurable. I will have it take KAFKA_AUTO_COMMIT_INTERVAL as and environmental override and default back to the previous value.

dan-du-car · 2026-05-12T17:58:15Z

Please update readme or other document that describe (including feature, purpose, interface etc) the modules in the architecture diagram. If the module codebase exist, please add link to the codebase.

Addressed here: https://github.com/usdot-jpo-ode/jpo-ode/blob/fix/retain-asn1-message-signature/docs/Architecture.md#52---architecture-module-reference

dan-du-car · 2026-05-12T18:12:45Z

@Michael7371 "Adding signature retention to metadata.asn1 field before stripping signature header off for decoding." I see the asn1 field is populated in the metadata, but where the signature retention logic is added?

… to include KAFKA_AUTO_COMMIT_INTERVAL environment variable; enhance README with architecture module reference and improve documentation structure in Architecture.md.

…ove error logging for header stripping failures. Update multiple receiver tests to remove assertions on ASN.1 string endings, ensuring consistency across test cases.

…ngs in JSON output. Update tests to validate that metadata matches CodecUtils serialization, enhancing reliability across various message types.

Michael7371 · 2026-05-15T17:23:40Z

@Michael7371 "Adding signature retention to metadata.asn1 field before stripping signature header off for decoding." I see the asn1 field is populated in the metadata, but where the signature retention logic is added?

The signature retention logic is added to the UdpHexDecoder's buildAsn1DataFromPacket function as it now returns a stripped asn1 hex string for the payload data but it retains the full IEE 1609.2 signature header and message frame payload in the metadata.asn1 field. Note that this does require the incoming UDP data to include the message signature when the UDP IFM is configured.

iyourshaw

The updates look good.

Just noticed an issue with the unit tests that is important, plus a few nitpicks.

…c OdeMsgPayload type. Update multiple receiver tests to utilize parameterized tests for improved readability and maintainability, ensuring consistent setup and teardown processes across test classes. Reverting default UDP receiver tests to use unsigned messaging. Added additional tests with signed messages.

…MP header" across multiple test classes for consistency. Refactor test input formatting for improved readability. Adjust test files to ensure proper newline endings and correct expected output values.

…ues and ensure proper newline endings. Remove unnecessary commas in JSON validation file for cleaner formatting.

Michael7371 · 2026-05-19T00:25:50Z

@@ -1 +1 @@
-0022e12d18466c65c1493800000e00e4616183e85a8f0100c000038081bc001480b8494c4c950cd8cde6e9651116579f22a424dd78fffff00761e4fd7eb7d07f7fff80005f11d1020214c1c0ffc7c016aff4017a0ff65403b0fd204c20ffccc04f8fe40c420ffe6404cefe60e9a10133408fcfde1438103ab4138f00e1eec1048ec160103e237410445c171104e26bc103dc4154305c2c84103b1c1c8f0a82f42103f34262d1123198103dac25fb12034ce10381c259f12038ca103574251b10e3b2210324c23ad0f23d8efffe0000209340d10000004264bf00
+001480b8494c4c950cd8cde6e9651116579f22a424dd78fffff00761e4fd7eb7d07f7fff80005f11d1020214c1c0ffc7c016aff4017a0ff65403b0fd204c20ffccc04f8fe40c420ffe6404cefe60e9a10133408fcfde1438103ab4138f00e1eec1048ec160103e237410445c171104e26bc103dc4154305c2c84103b1c1c8f0a82f42103f34262d1123198103dac25fb12034ce10381c259f12038ca103574251b10e3b2210324c23ad0f23d8efffe0000209340d10000004264bf00


I removed the message signature on this sample payload

Michael7371 · 2026-05-19T00:26:25Z

@@ -1 +1 @@
-011d0000201a0000021bd86891de75f84da101c13f042e2214141fff00022c2000270000000163b2cc7986010000
+00201a0000021bd86891de75f84da101c13f042e2214141fff00022c2000270000000163b2cc7986010000


Same payload with removed message signature.

…l test methods for improved clarity and maintainability. Update test input handling and ensure consistent formatting across all receiver test classes.

…for cleaner code.

…d of ASD signatures.

iyourshaw

looks good, issues have been addressed & verified unit tests pass

Michael7371 added 3 commits April 1, 2026 18:26

Add constructor to OdeMessageFrameMetadata for ASN.1 hex string; refa…

0200f7a

…ctor UdpHexDecoder to extract and log untrimmed payload hex

Add ASN.1 validation to receiver tests by asserting that produced ASN…

eea011b

….1 strings end with expected values across multiple receiver test classes.

update ODE TMC diagram

36c2fea

Michael7371 requested review from dan-du-car and moha-hafez May 8, 2026 17:07

github-actions Bot reviewed May 8, 2026

View reviewed changes

Comment thread jpo-ode-core/src/main/java/us/dot/its/jpo/ode/model/OdeMsgMetadata.java Outdated

Comment thread jpo-ode-core/src/main/java/us/dot/its/jpo/ode/model/OdeMsgMetadata.java Outdated

Comment thread jpo-ode-core/src/main/java/us/dot/its/jpo/ode/model/OdeMsgMetadata.java Outdated

Michael7371 added 3 commits May 8, 2026 11:12

resolve checkstyle formatting comments

af4381d

Update Kafka consumer configuration in application.yaml to adjust aut…

3711e95

…o-commit interval and add fetch-max-wait, retries, and linger.ms properties.

Enhance error logging in GenericReceiver to include detected message …

2f734b6

…type and improve packet description for troubleshooting.

Michael7371 requested a review from iyourshaw May 12, 2026 17:12

Michael7371 mentioned this pull request May 12, 2026

2026 Q2 Updates - Neaera Fork #597

Merged

12 tasks

dan-du-car reviewed May 12, 2026

View reviewed changes

iyourshaw reviewed May 13, 2026

View reviewed changes

Comment thread jpo-ode-svcs/src/main/resources/application.yaml Outdated

iyourshaw reviewed May 13, 2026

View reviewed changes

Comment thread jpo-ode-core/src/main/java/us/dot/its/jpo/ode/model/OdeMessageFrameMetadata.java

Michael7371 added 3 commits May 13, 2026 11:19

Update Kafka configuration in docker-compose.yml and application.yaml…

e1598af

… to include KAFKA_AUTO_COMMIT_INTERVAL environment variable; enhance README with architecture module reference and improve documentation structure in Architecture.md.

Enhance UdpHexDecoder to support stripping of 1609.2 headers and impr…

0d564c6

…ove error logging for header stripping failures. Update multiple receiver tests to remove assertions on ASN.1 string endings, ensuring consistency across test cases.

Refactor UdpHexDecoder to ensure consistent casing for ASN.1 hex stri…

eea0b91

…ngs in JSON output. Update tests to validate that metadata matches CodecUtils serialization, enhancing reliability across various message types.

github-actions Bot reviewed May 15, 2026

View reviewed changes

Comment thread jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/udp/UdpHexDecoder.java Outdated

Comment thread jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/udp/UdpHexDecoder.java Outdated

Michael7371 added 2 commits May 15, 2026 11:08

Reverting changes to unintended files

ff80952

resolve checkstyle comments

550717a

Michael7371 requested review from dan-du-car and iyourshaw May 15, 2026 17:23

iyourshaw requested changes May 18, 2026

View reviewed changes

Michael7371 added 3 commits May 18, 2026 14:43

Update receiver tests to replace "1609.3 WSMP header" with "1609.2 WS…

66755d5

…MP header" across multiple test classes for consistency. Refactor test input formatting for improved readability. Adjust test files to ensure proper newline endings and correct expected output values.

Update BSM and PSM receiver test files to correct expected output val…

7592f0b

…ues and ensure proper newline endings. Remove unnecessary commas in JSON validation file for cleaner formatting.

Michael7371 commented May 19, 2026

View reviewed changes

Michael7371 added 2 commits May 18, 2026 18:42

Refactor receiver tests to replace parameterized tests with individua…

aa29d7d

…l test methods for improved clarity and maintainability. Update test input handling and ensure consistent formatting across all receiver test classes.

Remove commented-out local UDP_IP assignment in udpsender_generic.py …

bf9acd5

…for cleaner code.

Michael7371 requested a review from iyourshaw May 19, 2026 00:46

iyourshaw reviewed May 19, 2026

View reviewed changes

Comment thread ...vcs/src/test/resources/us/dot/its/jpo/ode/udp/bsm/BsmReceiverTest_ValidBSM_WithSignature.txt Outdated

Comment thread ...vcs/src/test/resources/us/dot/its/jpo/ode/udp/psm/PsmReceiverTest_ValidPSM_WithSignature.txt Outdated

updated BSM and PSM receiver tests to use IEE1609.2 signatures instea…

7c10a92

…d of ASD signatures.

Michael7371 requested a review from iyourshaw May 20, 2026 19:05

iyourshaw approved these changes May 25, 2026

View reviewed changes

Michael7371 requested review from CCastillo027 and removed request for dan-du-car and moha-hafez May 27, 2026 15:19

CCastillo027 approved these changes Jun 2, 2026

View reviewed changes

Michael7371 merged commit 5d3f2c7 into develop Jun 2, 2026
5 checks passed

Michael7371 deleted the fix/retain-asn1-message-signature branch June 2, 2026 16:23

		@@ -1,16 +1,14 @@
		/*******************************************************************************
		* Copyright 2018 572682

		@@ -1 +1 @@
		0022e12d18466c65c1493800000e00e4616183e85a8f0100c000038081bc001480b8494c4c950cd8cde6e9651116579f22a424dd78fffff00761e4fd7eb7d07f7fff80005f11d1020214c1c0ffc7c016aff4017a0ff65403b0fd204c20ffccc04f8fe40c420ffe6404cefe60e9a10133408fcfde1438103ab4138f00e1eec1048ec160103e237410445c171104e26bc103dc4154305c2c84103b1c1c8f0a82f42103f34262d1123198103dac25fb12034ce10381c259f12038ca103574251b10e3b2210324c23ad0f23d8efffe0000209340d10000004264bf00 No newline at end of file
		001480b8494c4c950cd8cde6e9651116579f22a424dd78fffff00761e4fd7eb7d07f7fff80005f11d1020214c1c0ffc7c016aff4017a0ff65403b0fd204c20ffccc04f8fe40c420ffe6404cefe60e9a10133408fcfde1438103ab4138f00e1eec1048ec160103e237410445c171104e26bc103dc4154305c2c84103b1c1c8f0a82f42103f34262d1123198103dac25fb12034ce10381c259f12038ca103574251b10e3b2210324c23ad0f23d8efffe0000209340d10000004264bf00 No newline at end of file

		@@ -1 +1 @@
		011d0000201a0000021bd86891de75f84da101c13f042e2214141fff00022c2000270000000163b2cc7986010000 No newline at end of file
		00201a0000021bd86891de75f84da101c13f042e2214141fff00022c2000270000000163b2cc7986010000 No newline at end of file

Uh oh!

Conversation

Michael7371 commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Michael7371 May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dan-du-car commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Michael7371 commented May 15, 2026

Uh oh!

iyourshaw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

iyourshaw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Michael7371 commented May 8, 2026 •

edited

Loading

Michael7371 May 13, 2026 •

edited

Loading

dan-du-car commented May 12, 2026 •

edited

Loading