Skip to content

Conversation

@xgreenx
Copy link
Contributor

@xgreenx xgreenx commented Mar 10, 2022

Extracted push and pull of the contract in the dispatching logic to reduce the size of the contracts.

It is part of the #1017. It is easy to review and it can be part of a stable release=)

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1174 (0bcc986) into master (dd2e4fb) will increase coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
+ Coverage   78.54%   79.02%   +0.48%     
==========================================
  Files         229      229              
  Lines        8715     8667      -48     
==========================================
+ Hits         6845     6849       +4     
+ Misses       1870     1818      -52     
Impacted Files Coverage Δ
crates/lang/src/codegen/dispatch/execution.rs 0.00% <ø> (ø)
crates/lang/codegen/src/generator/dispatch.rs 94.49% <100.00%> (ø)
crates/lang/tests/ui/contract/pass/event-topics.rs 1.92% <0.00%> (+0.03%) ⬆️
...tes/lang/tests/ui/contract/pass/event-anonymous.rs 1.92% <0.00%> (+0.03%) ⬆️
...g/tests/ui/contract/pass/event-many-definitions.rs 2.63% <0.00%> (+0.06%) ⬆️
...tests/ui/contract/pass/event-config-more-topics.rs 3.57% <0.00%> (+0.12%) ⬆️
crates/lang/tests/ui/contract/pass/env-access.rs 4.00% <0.00%> (+0.15%) ⬆️
.../tests/ui/contract/pass/constructor-many-inputs.rs 6.66% <0.00%> (+0.41%) ⬆️
...ang/tests/ui/contract/pass/impl-block-using-env.rs 9.09% <0.00%> (+0.75%) ⬆️
...ts/ui/contract/pass/trait-message-payable-guard.rs 10.00% <0.00%> (+0.90%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2e4fb...0bcc986. Read the comment docs.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Mar 10, 2022

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the examples/* contracts from this branch with cargo-contract 0.17.0-191b588 and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator -0.10 K 1.03 K
adder +0.01 K 2.19 K
contract-introspection 2.39 K
contract-terminate 0.94 K 214_418
contract-transfer 8.15 K 14_418
delegator +0.27 K -314 6.39 K 46_302
dns -0.41 K 8.98 K 43_254
erc1155 -0.56 K 26.67 K 86_508
erc20 -0.35 K 8.60 K 43_254
erc721 -1.34 K 11.93 K 115_344
flipper -0.10 K 1.31 K 14_418
incrementer -0.10 K 1.21 K 14_418
multisig -0.55 K -260 25.33 K 93_541
proxy -0.13 K -48 2.93 K 29_538
rand-extension -0.21 K 4.00 K 14_418
subber +0.01 K 2.21 K
trait-erc20 -0.35 K 8.88 K 43_254
trait-flipper -0.10 K 1.00 K 14_418
trait-incrementer -0.09 K 1.19 K 28_836
upgradeable-contract -0.09 K 3.02 K

Link to the run | Last update: Fri Mar 11 08:29:47 CET 2022

Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ascjones ascjones merged commit 2c6502b into use-ink:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants