Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solidity compatible address and byte types #2397

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Solidity compatible address and byte types #2397

wants to merge 3 commits into from

Conversation

davidsemakula
Copy link
Contributor

@davidsemakula davidsemakula commented Feb 10, 2025 •
edited
Loading

Summary

Closes - N/A

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on a specific version of cargo-contract or pallet-revive?

Adds Address and Byte types that can be unambiguously mapped to Solidity's address and bytes<N> (and bytes) types.

Description

See this discussion for rationale and additional details.

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@davidsemakula davidsemakula mentioned this pull request Feb 10, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@ascjones ascjones Awaiting requested review from ascjones ascjones is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidsemakula