Skip to content

chore: Re-enable Solidity to ink! contract call integration test #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

chore: Re-enable Solidity to ink! contract call integration test #2497

wants to merge 2 commits into from

Conversation

@davidsemakula
Copy link
Collaborator

Summary

Closes #_

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on a specific version of cargo-contract or pallet-revive?

Description

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch and comparing them to ink! master:

Show overview

Using the ABI denoted in the contract manifest.

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
all-abi/events 19.58 19.58 0 0% ➖
call-builder-return-value 8.926 8.926 0 0% ➖
combined-extension 2.559 2.559 0 0% ➖
complex-storage-structures 4.626 4.626 0 0% ➖
conditional-compilation 1.494 1.494 0 0% ➖
contract-invocation 7.975 7.975 0 0% ➖
contract-invocation/contract1 1.851 1.851 0 0% ➖
contract-invocation/contract2 1.766 1.766 0 0% ➖
contract-invocation/virtual_contract 4.314 4.314 0 0% ➖
contract-invocation/virtual_contract_ver1 1.723 1.723 0 0% ➖
contract-invocation/virtual_contract_ver2 1.735 1.735 0 0% ➖
contract-storage 6.646 6.646 0 0% ➖
contract-terminate 1.315 1.315 0 0% ➖
contract-transfer 2.876 2.876 0 0% ➖
cross-contract-calls 8.49 8.49 0 0% ➖
cross-contract-calls/other-contract 1.542 1.542 0 0% ➖
custom-allocator 2.996 2.996 0 0% ➖
custom-environment 3.249 3.249 0 0% ➖
debugging-strategies 4.197 4.197 0 0% ➖
dns 9.171 9.171 0 0% ➖
e2e-call-runtime 1.725 1.725 0 0% ➖
e2e-runtime-only-backend 2.275 2.275 0 0% ➖
erc1155 20.415 20.415 0 0% ➖
erc20 10.744 10.744 0 0% ➖
erc721 12.166 12.166 0 0% ➖
events 8.747 8.747 0 0% ➖
flipper 1.542 1.542 0 0% ➖
fuzz-testing 1.528 1.528 0 0% ➖
incrementer 1.28 1.28 0 0% ➖
lang-err/call-builder 8.253 8.253 0 0% ➖
lang-err/call-builder-delegate 3.291 3.291 0 0% ➖
lang-err/constructors-return-value 2.174 2.174 0 0% ➖
lang-err/contract-ref 6.799 6.799 0 0% ➖
lang-err/integration-flipper 1.826 1.826 0 0% ➖
lazyvec 4.877 4.877 0 0% ➖
mapping 9.42 9.42 0 0% ➖
mother 15.763 15.763 0 0% ➖
multi-contract-caller 11.673 11.673 0 0% ➖
multi-contract-caller/accumulator 1.127 1.127 0 0% ➖
multi-contract-caller/adder 2.946 2.946 0 0% ➖
multi-contract-caller/subber 2.951 2.951 0 0% ➖
multisig 25.897 25.897 0 0% ➖
own-code-hash 2.591 2.591 0 0% ➖
payment-channel 7.826 7.826 0 0% ➖
psp22-extension 7.392 7.392 0 0% ➖
rand-extension 4.223 4.223 0 0% ➖
runtime-call-contract 1.545 1.545 0 0% ➖
solidity-abi/events 12.443 12.443 0 0% ➖
solidity-abi/fallible-setter 2.465 2.465 0 0% ➖
solidity-abi/sol-cross-contract 6.458 6.458 0 0% ➖
solidity-abi/sol-cross-contract/other-contract-sol 2.344 2.344 0 0% ➖
solidity-abi/sol-encoding 2.28 2.28 0 0% ➖
solidity-abi/solidity-calls-flipper 8.754 8.754 0 0% ➖
solidity-abi/trait-dyn-cross-contract-calls 5.807 5.807 0 0% ➖
solidity-abi/trait-dyn-cross-contract-calls/contracts/incrementer 2.12 2.12 0 0% ➖
solidity-abi/trait-flipper 2.028 2.028 0 0% ➖
sr25519-verification 0.851 0.851 0 0% ➖
static-buffer 2.516 2.516 0 0% ➖
storage-types 17.028 17.028 0 0% ➖
trait-dyn-cross-contract-calls 3.738 3.738 0 0% ➖
trait-dyn-cross-contract-calls/contracts/incrementer 1.571 1.571 0 0% ➖
trait-erc20 11.079 11.079 0 0% ➖
trait-flipper 1.495 1.495 0 0% ➖
trait-incrementer 1.631 1.631 0 0% ➖
upgradeable-contracts/delegator 6.211 6.211 0 0% ➖
upgradeable-contracts/delegator/delegatee 2.629 2.629 0 0% ➖
upgradeable-contracts/delegator/delegatee2 2.629 2.629 0 0% ➖
upgradeable-contracts/set-code-hash 1.494 1.494 0 0% ➖
upgradeable-contracts/set-code-hash-migration 1.494 1.494 0 0% ➖
upgradeable-contracts/set-code-hash-migration/migration 1.657 1.657 0 0% ➖
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.668 1.668 0 0% ➖
upgradeable-contracts/set-code-hash/updated-incrementer 1.446 1.446 0 0% ➖
wildcard-selector 2.738 2.738 0 0% ➖
Show diagram 
gantt
   dateFormat x
   axisFormat x
section  
all-abi/events : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 19580 kb       : a1, 0, 19580
pr default abi - 19580 kb      : a1, 0, 19580
pr sol abi - 19580 kb      : a2, 0, 19580
pr all abi - 19580 kb     : a3, 0, 19580
#nbsp; : a4, 0, 0

section  
call-builder-return-value : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 8926 kb       : a1, 0, 8926
pr default abi - 8926 kb      : a1, 0, 8926
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
combined-extension : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2559 kb       : a1, 0, 2559
pr default abi - 2559 kb      : a1, 0, 2559
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
complex-storage-structures : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 4626 kb       : a1, 0, 4626
pr default abi - 4626 kb      : a1, 0, 4626
pr sol abi - 7616 kb      : a2, 0, 7616
pr all abi - 9247 kb     : a3, 0, 9247
#nbsp; : a4, 0, 0

section  
conditional-compilation : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1494 kb       : a1, 0, 1494
pr default abi - 1494 kb      : a1, 0, 1494
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
contract-invocation : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 7975 kb       : a1, 0, 7975
pr default abi - 7975 kb      : a1, 0, 7975
pr sol abi - 11052 kb      : a2, 0, 11052
pr all abi - 12383 kb     : a3, 0, 12383
#nbsp; : a4, 0, 0

section  
contract-invocation/contract1 : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1851 kb       : a1, 0, 1851
pr default abi - 1851 kb      : a1, 0, 1851
pr sol abi - 2500 kb      : a2, 0, 2500
pr all abi - 3193 kb     : a3, 0, 3193
#nbsp; : a4, 0, 0

section  
contract-invocation/contract2 : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1766 kb       : a1, 0, 1766
pr default abi - 1766 kb      : a1, 0, 1766
pr sol abi - 2450 kb      : a2, 0, 2450
pr all abi - 3084 kb     : a3, 0, 3084
#nbsp; : a4, 0, 0

section  
contract-invocation/virtual_contract : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 4314 kb       : a1, 0, 4314
pr default abi - 4314 kb      : a1, 0, 4314
pr sol abi - 7148 kb      : a2, 0, 7148
pr all abi - 6692 kb     : a3, 0, 6692
#nbsp; : a4, 0, 0

section  
contract-invocation/virtual_contract_ver1 : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1723 kb       : a1, 0, 1723
pr default abi - 1723 kb      : a1, 0, 1723
pr sol abi - 2214 kb      : a2, 0, 2214
pr all abi - 2591 kb     : a3, 0, 2591
#nbsp; : a4, 0, 0

section  
contract-invocation/virtual_contract_ver2 : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1735 kb       : a1, 0, 1735
pr default abi - 1735 kb      : a1, 0, 1735
pr sol abi - 2226 kb      : a2, 0, 2226
pr all abi - 2618 kb     : a3, 0, 2618
#nbsp; : a4, 0, 0

section  
contract-storage : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 6646 kb       : a1, 0, 6646
pr default abi - 6646 kb      : a1, 0, 6646
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
contract-terminate : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1315 kb       : a1, 0, 1315
pr default abi - 1315 kb      : a1, 0, 1315
pr sol abi - 1282 kb      : a2, 0, 1282
pr all abi - 1410 kb     : a3, 0, 1410
#nbsp; : a4, 0, 0

section  
contract-transfer : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2876 kb       : a1, 0, 2876
pr default abi - 2876 kb      : a1, 0, 2876
pr sol abi - 2861 kb      : a2, 0, 2861
pr all abi - 3914 kb     : a3, 0, 3914
#nbsp; : a4, 0, 0

section  
cross-contract-calls : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 8490 kb       : a1, 0, 8490
pr default abi - 8490 kb      : a1, 0, 8490
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
cross-contract-calls/other-contract : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1542 kb       : a1, 0, 1542
pr default abi - 1542 kb      : a1, 0, 1542
pr sol abi - 2129 kb      : a2, 0, 2129
pr all abi - 2555 kb     : a3, 0, 2555
#nbsp; : a4, 0, 0

section  
custom-allocator : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2996 kb       : a1, 0, 2996
pr default abi - 2996 kb      : a1, 0, 2996
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
custom-environment : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 3249 kb       : a1, 0, 3249
pr default abi - 3249 kb      : a1, 0, 3249
pr sol abi - 1502 kb      : a2, 0, 1502
pr all abi - 3726 kb     : a3, 0, 3726
#nbsp; : a4, 0, 0

section  
debugging-strategies : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 4197 kb       : a1, 0, 4197
pr default abi - 4197 kb      : a1, 0, 4197
pr sol abi - 4917 kb      : a2, 0, 4917
pr all abi - 5586 kb     : a3, 0, 5586
#nbsp; : a4, 0, 0

section  
dns : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 9171 kb       : a1, 0, 9171
pr default abi - 9171 kb      : a1, 0, 9171
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
e2e-call-runtime : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1725 kb       : a1, 0, 1725
pr default abi - 1725 kb      : a1, 0, 1725
pr sol abi - 2351 kb      : a2, 0, 2351
pr all abi - 2986 kb     : a3, 0, 2986
#nbsp; : a4, 0, 0

section  
e2e-runtime-only-backend : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2275 kb       : a1, 0, 2275
pr default abi - 2275 kb      : a1, 0, 2275
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
erc1155 : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 20415 kb       : a1, 0, 20415
pr default abi - 20415 kb      : a1, 0, 20415
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
erc20 : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 10744 kb       : a1, 0, 10744
pr default abi - 10744 kb      : a1, 0, 10744
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
erc721 : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 12166 kb       : a1, 0, 12166
pr default abi - 12166 kb      : a1, 0, 12166
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
events : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 8747 kb       : a1, 0, 8747
pr default abi - 8747 kb      : a1, 0, 8747
pr sol abi - 13098 kb      : a2, 0, 13098
pr all abi - 18874 kb     : a3, 0, 18874
#nbsp; : a4, 0, 0

section  
flipper : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1542 kb       : a1, 0, 1542
pr default abi - 1542 kb      : a1, 0, 1542
pr sol abi - 2129 kb      : a2, 0, 2129
pr all abi - 2555 kb     : a3, 0, 2555
#nbsp; : a4, 0, 0

section  
fuzz-testing : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1528 kb       : a1, 0, 1528
pr default abi - 1528 kb      : a1, 0, 1528
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
incrementer : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1280 kb       : a1, 0, 1280
pr default abi - 1280 kb      : a1, 0, 1280
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
lang-err/call-builder : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 8253 kb       : a1, 0, 8253
pr default abi - 8253 kb      : a1, 0, 8253
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
lang-err/call-builder-delegate : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 3291 kb       : a1, 0, 3291
pr default abi - 3291 kb      : a1, 0, 3291
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
lang-err/constructors-return-value : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2174 kb       : a1, 0, 2174
pr default abi - 2174 kb      : a1, 0, 2174
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
lang-err/contract-ref : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 6799 kb       : a1, 0, 6799
pr default abi - 6799 kb      : a1, 0, 6799
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
lang-err/integration-flipper : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1826 kb       : a1, 0, 1826
pr default abi - 1826 kb      : a1, 0, 1826
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
lazyvec : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 4877 kb       : a1, 0, 4877
pr default abi - 4877 kb      : a1, 0, 4877
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
mapping : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 9420 kb       : a1, 0, 9420
pr default abi - 9420 kb      : a1, 0, 9420
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
mother : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 15763 kb       : a1, 0, 15763
pr default abi - 15763 kb      : a1, 0, 15763
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
multi-contract-caller : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 11673 kb       : a1, 0, 11673
pr default abi - 11673 kb      : a1, 0, 11673
pr sol abi - 16073 kb      : a2, 0, 16073
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
multi-contract-caller/accumulator : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1127 kb       : a1, 0, 1127
pr default abi - 1127 kb      : a1, 0, 1127
pr sol abi - 2005 kb      : a2, 0, 2005
pr all abi - 2554 kb     : a3, 0, 2554
#nbsp; : a4, 0, 0

section  
multi-contract-caller/adder : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2946 kb       : a1, 0, 2946
pr default abi - 2946 kb      : a1, 0, 2946
pr sol abi - 4841 kb      : a2, 0, 4841
pr all abi - 3220 kb     : a3, 0, 3220
#nbsp; : a4, 0, 0

section  
multi-contract-caller/subber : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2951 kb       : a1, 0, 2951
pr default abi - 2951 kb      : a1, 0, 2951
pr sol abi - 4849 kb      : a2, 0, 4849
pr all abi - 3240 kb     : a3, 0, 3240
#nbsp; : a4, 0, 0

section  
multisig : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 25897 kb       : a1, 0, 25897
pr default abi - 25897 kb      : a1, 0, 25897
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
own-code-hash : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2591 kb       : a1, 0, 2591
pr default abi - 2591 kb      : a1, 0, 2591
pr sol abi - 2484 kb      : a2, 0, 2484
pr all abi - 3136 kb     : a3, 0, 3136
#nbsp; : a4, 0, 0

section  
payment-channel : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 7826 kb       : a1, 0, 7826
pr default abi - 7826 kb      : a1, 0, 7826
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
psp22-extension : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 7392 kb       : a1, 0, 7392
pr default abi - 7392 kb      : a1, 0, 7392
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
rand-extension : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 4223 kb       : a1, 0, 4223
pr default abi - 4223 kb      : a1, 0, 4223
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
runtime-call-contract : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1545 kb       : a1, 0, 1545
pr default abi - 1545 kb      : a1, 0, 1545
pr sol abi - 2129 kb      : a2, 0, 2129
pr all abi - 2559 kb     : a3, 0, 2559
#nbsp; : a4, 0, 0

section  
solidity-abi/events : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 12443 kb       : a1, 0, 12443
pr default abi - 12443 kb      : a1, 0, 12443
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
solidity-abi/fallible-setter : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2465 kb       : a1, 0, 2465
pr default abi - 2465 kb      : a1, 0, 2465
pr sol abi - 2465 kb      : a2, 0, 2465
pr all abi - 2967 kb     : a3, 0, 2967
#nbsp; : a4, 0, 0

section  
solidity-abi/sol-cross-contract : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 6458 kb       : a1, 0, 6458
pr default abi - 6458 kb      : a1, 0, 6458
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
solidity-abi/sol-cross-contract/other-contract-sol : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2344 kb       : a1, 0, 2344
pr default abi - 2344 kb      : a1, 0, 2344
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
solidity-abi/sol-encoding : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2280 kb       : a1, 0, 2280
pr default abi - 2280 kb      : a1, 0, 2280
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
solidity-abi/solidity-calls-flipper : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 8754 kb       : a1, 0, 8754
pr default abi - 8754 kb      : a1, 0, 8754
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
solidity-abi/trait-dyn-cross-contract-calls : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 5807 kb       : a1, 0, 5807
pr default abi - 5807 kb      : a1, 0, 5807
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
solidity-abi/trait-dyn-cross-contract-calls/contracts/incrementer : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2120 kb       : a1, 0, 2120
pr default abi - 2120 kb      : a1, 0, 2120
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
solidity-abi/trait-flipper : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2028 kb       : a1, 0, 2028
pr default abi - 2028 kb      : a1, 0, 2028
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
sr25519-verification : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 851 kb       : a1, 0, 851
pr default abi - 851 kb      : a1, 0, 851
pr sol abi - 776 kb      : a2, 0, 776
pr all abi - 979 kb     : a3, 0, 979
#nbsp; : a4, 0, 0

section  
static-buffer : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2516 kb       : a1, 0, 2516
pr default abi - 2516 kb      : a1, 0, 2516
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
storage-types : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 17028 kb       : a1, 0, 17028
pr default abi - 17028 kb      : a1, 0, 17028
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
trait-dyn-cross-contract-calls : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 3738 kb       : a1, 0, 3738
pr default abi - 3738 kb      : a1, 0, 3738
pr sol abi - 5807 kb      : a2, 0, 5807
pr all abi - 4537 kb     : a3, 0, 4537
#nbsp; : a4, 0, 0

section  
trait-dyn-cross-contract-calls/contracts/incrementer : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1571 kb       : a1, 0, 1571
pr default abi - 1571 kb      : a1, 0, 1571
pr sol abi - 2120 kb      : a2, 0, 2120
pr all abi - 2548 kb     : a3, 0, 2548
#nbsp; : a4, 0, 0

section  
trait-erc20 : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 11079 kb       : a1, 0, 11079
pr default abi - 11079 kb      : a1, 0, 11079
pr sol abi - 0 kb      : a2, 0, 0
pr all abi - 0 kb     : a3, 0, 0
#nbsp; : a4, 0, 0

section  
trait-flipper : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1495 kb       : a1, 0, 1495
pr default abi - 1495 kb      : a1, 0, 1495
pr sol abi - 2028 kb      : a2, 0, 2028
pr all abi - 2381 kb     : a3, 0, 2381
#nbsp; : a4, 0, 0

section  
trait-incrementer : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1631 kb       : a1, 0, 1631
pr default abi - 1631 kb      : a1, 0, 1631
pr sol abi - 2284 kb      : a2, 0, 2284
pr all abi - 2803 kb     : a3, 0, 2803
#nbsp; : a4, 0, 0

section  
upgradeable-contracts/delegator : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 6211 kb       : a1, 0, 6211
pr default abi - 6211 kb      : a1, 0, 6211
pr sol abi - 9367 kb      : a2, 0, 9367
pr all abi - 11311 kb     : a3, 0, 11311
#nbsp; : a4, 0, 0

section  
upgradeable-contracts/delegator/delegatee : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2629 kb       : a1, 0, 2629
pr default abi - 2629 kb      : a1, 0, 2629
pr sol abi - 2466 kb      : a2, 0, 2466
pr all abi - 3234 kb     : a3, 0, 3234
#nbsp; : a4, 0, 0

section  
upgradeable-contracts/delegator/delegatee2 : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2629 kb       : a1, 0, 2629
pr default abi - 2629 kb      : a1, 0, 2629
pr sol abi - 2468 kb      : a2, 0, 2468
pr all abi - 3234 kb     : a3, 0, 3234
#nbsp; : a4, 0, 0

section  
upgradeable-contracts/set-code-hash : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1494 kb       : a1, 0, 1494
pr default abi - 1494 kb      : a1, 0, 1494
pr sol abi - 2163 kb      : a2, 0, 2163
pr all abi - 2752 kb     : a3, 0, 2752
#nbsp; : a4, 0, 0

section  
upgradeable-contracts/set-code-hash-migration : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1494 kb       : a1, 0, 1494
pr default abi - 1494 kb      : a1, 0, 1494
pr sol abi - 2163 kb      : a2, 0, 2163
pr all abi - 2752 kb     : a3, 0, 2752
#nbsp; : a4, 0, 0

section  
upgradeable-contracts/set-code-hash-migration/migration : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1657 kb       : a1, 0, 1657
pr default abi - 1657 kb      : a1, 0, 1657
pr sol abi - 2397 kb      : a2, 0, 2397
pr all abi - 2362 kb     : a3, 0, 2362
#nbsp; : a4, 0, 0

section  
upgradeable-contracts/set-code-hash-migration/updated-incrementer : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1668 kb       : a1, 0, 1668
pr default abi - 1668 kb      : a1, 0, 1668
pr sol abi - 2713 kb      : a2, 0, 2713
pr all abi - 3198 kb     : a3, 0, 3198
#nbsp; : a4, 0, 0

section  
upgradeable-contracts/set-code-hash/updated-incrementer : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 1446 kb       : a1, 0, 1446
pr default abi - 1446 kb      : a1, 0, 1446
pr sol abi - 2147 kb      : a2, 0, 2147
pr all abi - 2692 kb     : a3, 0, 2692
#nbsp; : a4, 0, 0

section  
wildcard-selector : a5, 0, 0
v5 default abi - 0 kb       : a1, 0, 0
master default abi - 2738 kb       : a1, 0, 2738
pr default abi - 2738 kb      : a1, 0, 2738
pr sol abi - 4535 kb      : a2, 0, 4535
pr all abi - 4950 kb     : a3, 0, 4950
#nbsp; : a4, 0, 0
Loading
Show contract sizes: ink! vs Solidity ABI

The following table shows how the contract sizes on this branch change when choosing the Solidity ABI instead of the ink! ABI.

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
all-abi/events 19.58 19.58 0 0% ➖
complex-storage-structures 4.626 7.616 2.99 65% 📈
contract-invocation 7.975 11.052 3.077 39% 📈
contract-invocation/contract1 1.851 2.5 0.649 35% 📈
contract-invocation/contract2 1.766 2.45 0.684 39% 📈
contract-invocation/virtual_contract 4.314 7.148 2.834 66% 📈
contract-invocation/virtual_contract_ver1 1.723 2.214 0.491 28% 📈
contract-invocation/virtual_contract_ver2 1.735 2.226 0.491 28% 📈
contract-terminate 1.315 1.282 -0.033 -2% 📉
contract-transfer 2.876 2.861 -0.015 0% 📉
cross-contract-calls/other-contract 1.542 2.129 0.587 38% 📈
custom-environment 3.249 1.502 -1.747 -53% 📉
debugging-strategies 4.197 4.917 0.72 17% 📈
e2e-call-runtime 1.725 2.351 0.626 36% 📈
events 8.747 13.098 4.351 50% 📈
flipper 1.542 2.129 0.587 38% 📈
multi-contract-caller 11.673 16.073 4.4 38% 📈
multi-contract-caller/accumulator 1.127 2.005 0.878 78% 📈
multi-contract-caller/adder 2.946 4.841 1.895 64% 📈
multi-contract-caller/subber 2.951 4.849 1.898 64% 📈
own-code-hash 2.591 2.484 -0.107 -3% 📉
runtime-call-contract 1.545 2.129 0.584 38% 📈
solidity-abi/fallible-setter 2.465 2.465 0 0% ➖
sr25519-verification 0.851 0.776 -0.075 -8% 📉
trait-dyn-cross-contract-calls 3.738 5.807 2.069 55% 📈
trait-dyn-cross-contract-calls/contracts/incrementer 1.571 2.12 0.549 35% 📈
trait-flipper 1.495 2.028 0.533 36% 📈
trait-incrementer 1.631 2.284 0.653 40% 📈
upgradeable-contracts/delegator 6.211 9.367 3.156 51% 📈
upgradeable-contracts/delegator/delegatee 2.629 2.466 -0.163 -5% 📉
upgradeable-contracts/delegator/delegatee2 2.629 2.468 -0.161 -5% 📉
upgradeable-contracts/set-code-hash 1.494 2.163 0.669 45% 📈
upgradeable-contracts/set-code-hash-migration 1.494 2.163 0.669 45% 📈
upgradeable-contracts/set-code-hash-migration/migration 1.657 2.397 0.74 45% 📈
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.668 2.713 1.045 63% 📈
upgradeable-contracts/set-code-hash/updated-incrementer 1.446 2.147 0.701 48% 📈
wildcard-selector 2.738 4.535 1.797 66% 📈
Show contract sizes: ink! vs all ABI

The following table shows how the contract sizes on this branch change when choosing the all ABI instead of the ink! ABI.

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
all-abi/events 19.58 19.58 0 0% ➖
complex-storage-structures 4.626 9.247 4.621 100% 📈
contract-invocation 7.975 12.383 4.408 55% 📈
contract-invocation/contract1 1.851 3.193 1.342 73% 📈
contract-invocation/contract2 1.766 3.084 1.318 75% 📈
contract-invocation/virtual_contract 4.314 6.692 2.378 55% 📈
contract-invocation/virtual_contract_ver1 1.723 2.591 0.868 50% 📈
contract-invocation/virtual_contract_ver2 1.735 2.618 0.883 51% 📈
contract-terminate 1.315 1.41 0.095 7% 📈
contract-transfer 2.876 3.914 1.038 36% 📈
cross-contract-calls/other-contract 1.542 2.555 1.013 66% 📈
custom-environment 3.249 3.726 0.477 15% 📈
debugging-strategies 4.197 5.586 1.389 33% 📈
e2e-call-runtime 1.725 2.986 1.261 73% 📈
events 8.747 18.874 10.127 116% 📈
flipper 1.542 2.555 1.013 66% 📈
multi-contract-caller/accumulator 1.127 2.554 1.427 127% 📈
multi-contract-caller/adder 2.946 3.22 0.274 9% 📈
multi-contract-caller/subber 2.951 3.24 0.289 10% 📈
own-code-hash 2.591 3.136 0.545 21% 📈
runtime-call-contract 1.545 2.559 1.014 66% 📈
solidity-abi/fallible-setter 2.465 2.967 0.502 20% 📈
sr25519-verification 0.851 0.979 0.128 15% 📈
trait-dyn-cross-contract-calls 3.738 4.537 0.799 21% 📈
trait-dyn-cross-contract-calls/contracts/incrementer 1.571 2.548 0.977 62% 📈
trait-flipper 1.495 2.381 0.886 59% 📈
trait-incrementer 1.631 2.803 1.172 72% 📈
upgradeable-contracts/delegator 6.211 11.311 5.1 82% 📈
upgradeable-contracts/delegator/delegatee 2.629 3.234 0.605 23% 📈
upgradeable-contracts/delegator/delegatee2 2.629 3.234 0.605 23% 📈
upgradeable-contracts/set-code-hash 1.494 2.752 1.258 84% 📈
upgradeable-contracts/set-code-hash-migration 1.494 2.752 1.258 84% 📈
upgradeable-contracts/set-code-hash-migration/migration 1.657 2.362 0.705 43% 📈
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.668 3.198 1.53 92% 📈
upgradeable-contracts/set-code-hash/updated-incrementer 1.446 2.692 1.246 86% 📈
wildcard-selector 2.738 4.95 2.212 81% 📈

Link to the run | Last update: Sun Aug 31 10:49:40 CEST 2025

@davidsemakula davidsemakula force-pushed the semakula/sol-ink-call branch from 630edb5 to 77e00fd Compare May 4, 2025 10:49
@davidsemakula davidsemakula force-pushed the semakula/sol-ink-call branch from 77e00fd to c8c44bd Compare August 30, 2025 20:05
@davidsemakula davidsemakula force-pushed the semakula/sol-ink-call branch from 9aa24a6 to 2c4ef1e Compare August 31, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmichi cmichi Awaiting requested review from cmichi cmichi will be requested when the pull request is marked ready for review cmichi is a code owner

@AlexD10S AlexD10S Awaiting requested review from AlexD10S AlexD10S will be requested when the pull request is marked ready for review AlexD10S is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidsemakula