Fix: user defined cookies getting overwritten by stored cookies #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues: #2102, #1944
When a user sends the first request with a user-defined Cookie header, the request works as expected. However, the response from the server may include Set-Cookie headers. When the user sends a subsequent request, these cookies overwrite the user-defined cookies, leading to unexpected behavior.
Solution
This PR resolves the issue by merging the user-defined Cookie header with the cookies received from the server's Set-Cookie response. Both sets of cookies are now combined into a single Cookie header, ensuring that user-defined cookies are preserved while including any additional cookies set by the server.
Contribution Checklist:
Screen.Recording.2025-01-21.at.3.43.37.PM.mov