Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ Handle Folder settings stale uids (fixes: #3864) #3866

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Pragadesh-45
Copy link
Contributor

@Pragadesh-45 Pragadesh-45 commented Jan 23, 2025

fixes: #3864

Description

This PR implements a fix for the app crash issue that occurs when headers are opened in folder settings, and then we try to move that folder. The issue is caused by using stale header UIDs in non-existent folders. The only action allowed in this case should be closing the stale tab.

Added auto-close to close stale tabs.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Before:

20250123-0820-15.3817888.mp4

After:

20250123-0821-28.2410971.mp4

Copy link
Contributor

@helloanoop helloanoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not happy with so many conditionals being introduced to fix this issue. I'd like to understand the solutioning here better.

@Pragadesh44-Bruno lets discuss this once you are back from vacation next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when moving folders
3 participants