Skip to content

'Authentication failed' message converted in plain text #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sviluppomania wants to merge 1 commit into
base: master
Choose a base branch
from
Open

'Authentication failed' message converted in plain text #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion class-auth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public function get_token( WP_REST_Request $request ) {
'success' => false,
'statusCode' => 401,
'code' => $error_code,
'message' => strip_tags( $user->get_error_message( $error_code ) ),
'message' => strip_tags('Authentication failed: '.$error_code),
Copy link
Collaborator

@sun sun Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing code removes HTML tags already, so I'm not sure what this PR actually changes (other than removing a potentially more helpful error message for the end-user)…?

'data' => array(),
),
401
Expand Down