Skip to content

refactor: consolidate podtemplate spec creation #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: consolidate podtemplate spec creation #431

wants to merge 1 commit into from

Conversation

shreddedbacon
Copy link
Member

Just consolidates the pod template spec generation into one function.

Since Deployment and Cronjob both build mostly the same way, when changes are made to one, they're usually made to the other. This just makes them share the same code to make changes easier.

@shreddedbacon shreddedbacon marked this pull request as ready for review May 19, 2025 23:15
@bomoko bomoko self-requested a review May 22, 2025 23:14
bomoko
bomoko approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make a lot of sense. I've tested this on a lagoon - however, I do think we might want to look at factoring generatePodTemplateSpec into sub functions, just to make it a little less overwhelming to follow all the subsections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomoko bomoko bomoko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @bomoko