Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiosk improve highlighting in reservations questions #260

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

r-xyz
Copy link
Contributor

@r-xyz r-xyz commented Nov 11, 2024

Closes #256

From #256 (comment)
rpmat57:
I am think 1 and 2 and also make the asterisk bold.
for 2 make sure the color of the background passes the accessibility requirements (I use Wave chrome extension for that: https://chromewebstore.google.com/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh?hl=en-US&utm_source=ext_sidebar)

Implemented # 1 & 2.
Also changed the placeholder color so it can pass accessibility requirements. It is closer to normal text, though.
Feel free to suggest changes in colors.
Asterisk required to also increase size in addition to bold.
image

NEMO/static/nemo.css Outdated Show resolved Hide resolved
@rptmat57
Copy link
Contributor

thanks, this looks good.

It needs to be added in static/admin/dynamic_form_preview.css as well.

Sort of separate from this, but I am wondering if it would make more sense to wrap the dynamic form rendered html in a span/div with a dynamic_form class that could be used everywhere, rather than having to specify #tool_control and #additional_event_parameters. It would probably be more flexible.

What do you think?

@r-xyz r-xyz requested a review from rptmat57 November 20, 2024 01:45
@rptmat57
Copy link
Contributor

Looks great, thanks!

@rptmat57 rptmat57 merged commit 2481232 into usnistgov:6.1.0.dev Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants