Add Uint8ClampedArray
to TypedArray_to_dtype
mapping
#94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
create_dataset
withdata
that is aUint8ClampedArray
, the library throws the error"DataView not supported directly for write"
.This appears to be because the
TypedArray_to_dtype
is missing a mapping for that array type, even though it is a permissible array type based on theGuessableDataTypes
andTypedArray
types.This PR updates the mapping so
Uint8ClampedArray
s can be provided as thedata
parameter tocreate_dataset
.