Update the MetadataService classes to work in a public/MIDAS-consolidated code base #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* nerdm.service.ts: introuduce SupportsAuthentication interface * errors.ts: refine available throwables * dap.service.ts: introduce MIDASDAPService, MIDASDAPUpdateService
* fill out DAPUpdateService interface and implementations * error.ts: add PartNotFound Error class * uprev @types/node to support midasdap.service.ts fix filters.component.spec.ts import error resulting from Angular upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #59 to provide a consolidated model for accessing NERDm data. The design is described in the Confluence document, Consolidating Landing Page Codebase: NERDm Module Consolidation. This PR will not be merged via GitHub; rather @chuanlin2018 will manually merge it into his consolidation branch by hand. This PR exists to highlight the changed classes.