Apple Virtualization: only update shared directories if they changed to avoid unnecessary virtiofs reconnections #7494
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid unnecessary virtiofs reconnections
For Apple Virtualization, only update shared directories if they changed to avoid unnecessary virtiofs reconnections.
Although this issue existed prior to v4.5.4, following v4.5.4, UTM introduced dynamic resolution. Resizing
the window with dynamic resolution is one repeatable way to cause a registry update. updateConfigFromRegistry()
updates the shared directories on every call, causing the virtiofs to reconnect. As the virtiofs disconnects
and reconnects, file and directory handles on the share are invalidated causing guest application errors.
To reproduce bug:
- Apple Virtualization, Linux guest, Dynamic resolution enabled
- Open terminal
- $ cd {shared_directory}
- Resize the window
- $ ls
- Result: ls: cannot open directory '.': No such file or directory
Author
|
Fixes #7488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Apple Virtualization, only update shared directories if they changed to avoid unnecessary virtiofs reconnections.
Although this issue existed prior to v4.5.4, following v4.5.4, UTM introduced dynamic resolution. Resizing the window with dynamic resolution is a repeatable way to cause a registry update. updateConfigFromRegistry() updates the shared directories on every call, causing the virtiofs to reconnect. As the virtiofs disconnects and reconnects, file and directory handles on the share are invalidated causing guest application errors.
To reproduce bug:
Thank you to @kraju for the hint that the issue started in v4.5.4.