Skip to content

Fix sketch v53 #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ellunium wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix sketch v53 #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea1c356
Support Sketch v53
ellunium Feb 19, 2019
92889bd
Fix for Sketch v53+
ellunium Feb 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions Sketch Measure.sketchplugin/Contents/Sketch/library/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1428,7 +1428,7 @@ SM.extend({
});

this.removeLayer(temp);
container.resizeToFitChildrenWithOption(0);
container.fixGeometryWithOptions(0);
},
spacings: function( options ){
var options = this.extend(options, {}),
Expand Down Expand Up @@ -1565,7 +1565,7 @@ SM.extend({
overlayRect.setWidth(targetRect.width);
overlayRect.setHeight(targetRect.height);

container.resizeToFitChildrenWithOption(0);
container.fixGeometryWithOptions(0);
}
});

Expand Down Expand Up @@ -1713,7 +1713,7 @@ SM.extend({

this.setConfigs({placement: placement}, container);

container.resizeToFitChildrenWithOption(0);
container.fixGeometryWithOptions(0);
}
});

Expand Down Expand Up @@ -2007,7 +2007,7 @@ SM.extend({
noteRect.setWidth(textRect.width + 12 * scale);
noteRect.setHeight(textRect.height + 12 * scale);

container.resizeToFitChildrenWithOption(0);
container.fixGeometryWithOptions(0);
this.removeLayer(target);
}
});
Expand Down Expand Up @@ -2082,7 +2082,7 @@ SM.extend({
text.setTextBehaviour(1);
text.setTextBehaviour(0);

container.resizeToFitChildrenWithOption(0);
container.fixGeometryWithOptions(0);
},
resizeNote: function(container) {
var text = this.find({key: "(class != NULL) && (class == %@)", match: MSTextLayer}),
Expand All @@ -2109,7 +2109,7 @@ SM.extend({
text.setTextBehaviour(1);
text.setTextBehaviour(0);

container.resizeToFitChildrenWithOption(0);
container.fixGeometryWithOptions(0);
}
});

Expand Down Expand Up @@ -2612,9 +2612,9 @@ SM.extend({
var symbolRect = this.getRect(layer),
symbolChildren = layer.symbolMaster().children(),
tempSymbol = layer.duplicate(),
tempGroup = tempSymbol.detachByReplacingWithGroup();
tempGroup = tempSymbol.detachStylesAndReplaceWithGroupRecursively(0);

tempGroup.resizeToFitChildrenWithOption(0)
tempGroup.fixGeometryWithOptions(0)

var tempSymbolLayers = tempGroup.children().objectEnumerator(),
overrides = layer.overrides(),
Expand Down Expand Up @@ -2643,11 +2643,10 @@ SM.extend({
self.getLayer(
artboard,
tempSymbolLayer,
data,
symbolChildren[idx]
data
);
}
idx++
idx++;
}
this.removeLayer(tempGroup);
}
Expand Down
2 changes: 1 addition & 1 deletion Sketch Measure.sketchplugin/Contents/Sketch/library/i18n/manifest-en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
"identifier": "com.utom.measure",
"appcast": "https://raw.githubusercontent.com/utom/sketch-measure/master/appcast.xml",
"homepage": "http://utom.design/measure/",
"version": "2.7.7",
"version": "2.7.8",
"description" : "Make it a fun to create spec for developers and teammates",
"authorEmail" : "[email protected]",
"name" : "Sketch Measure"
Expand Down
2 changes: 1 addition & 1 deletion Sketch Measure.sketchplugin/Contents/Sketch/library/i18n/manifest-zh-Hans.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@
"identifier": "com.utom.measure",
"appcast": "https://raw.githubusercontent.com/utom/sketch-measure/master/appcast.xml",
"homepage": "http://utom.design/measure/",
"version": "2.7.7",
"version": "2.7.8",
"description" : "Make it a fun to create spec for developers and teammates",
"authorEmail" : "[email protected]",
"name" : "Sketch Measure"
Expand Down
2 changes: 1 addition & 1 deletion Sketch Measure.sketchplugin/Contents/Sketch/library/i18n/manifest-zh-Hant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@
"identifier": "com.utom.measure",
"appcast": "https://raw.githubusercontent.com/utom/sketch-measure/master/appcast.xml",
"homepage": "http://utom.design/measure/",
"version": "2.7.7",
"version": "2.7.8",
"description" : "Make it a fun to create spec for developers and teammates",
"authorEmail" : "[email protected]",
"name" : "Sketch Measure"
Expand Down
2 changes: 1 addition & 1 deletion Sketch Measure.sketchplugin/Contents/Sketch/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
"identifier": "com.utom.measure",
"appcast": "https://raw.githubusercontent.com/utom/sketch-measure/master/appcast.xml",
"homepage": "http://utom.design/measure/",
"version": "2.7.7",
"version": "2.7.8",
"description" : "Make it a fun to create spec for developers and teammates",
"authorEmail" : "[email protected]",
"name" : "Sketch Measure"
Expand Down
6 changes: 3 additions & 3 deletions appcast.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
<description>Make it a fun to create spec for developers and teammates</description>
<language>en</language>
<item>
<title>Version 2.7.7</title>
<title>Version 2.7.8</title>
<description>
<![CDATA[
<ul>
<li>Support Sketch v52</li>
<li>Support Sketch v53</li>
</ul>
]]>
</description>
<enclosure url="https://github.com/utom/sketch-measure/archive/master.zip" sparkle:version="2.7.7" type="application/octet-stream" />
<enclosure url="https://github.com/utom/sketch-measure/archive/master.zip" sparkle:version="2.7.8" type="application/octet-stream" />
</item>
</channel>
</rss>