Skip to content

feat: implement react/no-forward-ref - #1098

Merged
fireairforce merged 1 commit into
mainfrom
zoomdong/issue-1094-react-no-forward-ref
Aug 26, 2026
Merged

feat: implement react/no-forward-ref#1098
fireairforce merged 1 commit into
mainfrom
zoomdong/issue-1094-react-no-forward-ref

Conversation

@fireairforce

Copy link
Copy Markdown
Member

Summary

  • add native, opt-in react/no-forward-ref support for React 19 projects
  • detect named and aliased imports plus default and namespace member calls from react
  • resolve semantic bindings so local functions, shadowed parameters, other-module imports, and unrelated methods named forwardRef are ignored
  • keep the rule diagnostic-only and expose it through project config, --rules, and the npm wrapper
  • document the new rule

Parser audit

  • exercised .js, .jsx, .ts, and .tsx fixtures
  • asserted zero parse diagnostics for every fixture
  • no Yuku parser regression observed with v0.9.1

Testing

  • zig build test --summary all — 1960/1960 tests passed
  • zig build
  • git diff --check

Closes #1094

@codspeed-hq

codspeed-hq Bot commented Aug 25, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 22.14%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark

Performance Changes

Benchmark BASE HEAD Efficiency
utoo-lint/fixtures/codspeed 171.8 ms 140.7 ms +22.14%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing zoomdong/issue-1094-react-no-forward-ref (61e9b02) with main (ab5c509)

Open in CodSpeed

@fireairforce
fireairforce merged commit df9d401 into main Aug 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement react/no-forward-ref

1 participant